Bug 429039 - dir_index can be removed from anaconda's tune2fs options
Summary: dir_index can be removed from anaconda's tune2fs options
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Anaconda Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-01-16 23:02 UTC by Eric Sandeen
Modified: 2008-01-16 23:28 UTC (History)
0 users

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-01-16 23:28:07 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Eric Sandeen 2008-01-16 23:02:03 UTC
setExt3Options in fsset.py tunes a few things:

        rc = iutil.execWithRedirect("tune2fs",
                                    ["-c0", "-i0", "-Odir_index",
                                     "-ouser_xattr,acl", devicePath],
                                    stdout = "/dev/tty5",
                                    stderr = "/dev/tty5", searchPath = 1)

-Odir_index is no longer necessary; it's part of the defaults in the binary and
mke2fs.conf:

const char *mke2fs_default_profile =
  "[defaults]\n"
  "     base_features = sparse_super,filetype,resize_inode,dir_index\n"
  "     blocksize = 4096\n"
  "     inode_ratio = 8192\n"
  "\n"
....

Not a big deal but no need to have redundant cruft in there.

Also, not sure why user_xattr & acl aren't default in ext3, but they're not
AFAICT so I guess they can stay here....

Thanks,
-Eric


Note You need to log in before you can comment on or make changes to this bug.