SRPM URL: http://fedora.biggerontheinside.net/review/perl-Convert-NLS_DATE_FORMAT-0.02-1.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Convert-NLS_DATE_FORMAT.spec Description: Convert Oracle's NLS_DATE_FORMAT string into a strptime format string, or the reverse.
Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url e2c42e8d082addb3762de99861be341d Convert-NLS_DATE_FORMAT-0.02.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave t/oracle2posix....ok t/posix2oracle....ok All tests successful. Files=2, Tests=25, 0 wallclock secs ( 0.04 cusr + 0.01 csys = 0.05 CPU) +Package perl-Convert-NLS_DATE_FORMAT-0.02-1.fc9 => Provides: perl(Convert::NLS_DATE_FORMAT) = 0.02 Requires: perl >= 0:5.006 perl(:MODULE_COMPAT_5.8.8) perl(Exporter) perl(strict) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Convert-NLS_DATE_FORMAT Short Description: Convert Oracle NLS_DATE_FORMAT <-> strftime Format Strings Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig
cvs done.
Imported and building. Thanks for the review! :)
Package Change Request ====================== Package Name: perl-Convert-NLS_DATE_FORMAT New Branches: el6 Owners: psabata InitialCC: perl-sig
Git done (by process-git-requests).
Package Change Request ====================== Package Name: perl-Convert-NLS_DATE_FORMAT New Branches: epel7 Owners: psabata dfateyev InitialCC: perl-sig