Bug 429749 (libvncserver) - Review Request: libvncserver - Library to make writing a vnc server easy
Summary: Review Request: libvncserver - Library to make writing a vnc server easy
Alias: libvncserver
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2008-01-22 21:08 UTC by Rex Dieter
Modified: 2014-06-03 12:21 UTC (History)
3 users (show)

Fixed In Version: 0.9.1-2.fc8
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-02-02 01:19:57 UTC
tibbs: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Rex Dieter 2008-01-22 21:08:31 UTC
Spec URL: http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/libvncserver/libvncserver.spec
SRPM URL: http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/libvncserver/libvncserver-0.9.1-1.src.rpm
LibVNCServer makes writing a VNC server (or more correctly, a program
exporting a framebuffer via the Remote Frame Buffer protocol) easy.

It hides the programmer from the tedious task of managing clients and
compression schemata.

Needed as builddep for kdenetwork >= 4.0.0

Comment 1 Jason Tibbitts 2008-01-26 23:09:37 UTC
Builds OK; rpmlint says:
  libvncserver.x86_64: W: file-not-utf8 /usr/share/doc/libvncserver-0.9.1/AUTHORS
Easy to fix with iconv
  libvncserver.x86_64: W: unused-direct-shlib-dependency 
   /usr/lib64/libvncclient.so.0.0.0 /lib64/libnsl.so.1
  libvncserver.x86_64: W: unused-direct-shlib-dependency 
   /usr/lib64/libvncserver.so.0.0.0 /lib64/libnsl.so.1
I don't think these are a big deal.

  libvncserver-debuginfo.x86_64: W: spurious-executable-perm 
  libvncserver-debuginfo.x86_64: W: spurious-executable-perm 
and so on for a bunch of .c and .h files.  A quick chmod should fix these up.

  libvncserver-devel.x86_64: W: no-documentation
Not a problem.

I'll whip up the rest of a review in a bit.

Comment 2 Jason Tibbitts 2008-01-27 01:55:56 UTC
So everything looks good to me except for the source file permissions and that

* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* debuginfo package looks complete.
X rpmlint has valid complaints.
* final provides and requires are sane:
   LibVNCServer = 0.9.1-1.fc9
   libvncserver = 0.9.1-1.fc9

   LibVNCServer-devel = 0.9.1-1.fc9
   libvncserver-devel = 0.9.1-1.fc9
   libvncserver = 0.9.1-1.fc9

* %check is not present.  There is a test suite, but it's not something which 
   could be run automatically at build time.
* shared libraries installed; ldconfig called properly.
* unversioned .so files are in the -devel package.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
X some odd file permissions
* scriptlets are OK (ldconfig)
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* headers are in the -devel package.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

Comment 3 Rex Dieter 2008-01-27 21:03:22 UTC
* Sun Jan 27 2008 Rex Dieter <rdieter@fedoraproject.org> 0.9.1-2
- hack libtool to omit unused shlib dependencies
- fix AUTHORS encoding
- fix src perms

Spec URL:

dist-f9 scratch build:

Comment 4 Rex Dieter 2008-01-31 16:29:50 UTC
tibbs, ping, anything else? 

(I'd like to incorporate this BR into the kdenetwork-4.0.1 build I'm comitting
later today, if possible).

Comment 5 Jason Tibbitts 2008-01-31 16:36:02 UTC
I've just been a bit time-limited over the past few days.  I'll try to gather
some time later today to finish this.

Comment 6 Jason Tibbitts 2008-01-31 19:50:13 UTC
OK, rpmlint is down to:
  libvncserver-devel.x86_64: W: no-documentation
which is OK.
The errant permissions are fixed.
Everything else still looks good.


Comment 7 Rex Dieter 2008-01-31 20:07:57 UTC
thanks!  excellent review (as usual).

New Package CVS Request
Package Name: libvncserver
Short Description: Library to make writing a vnc server easy
Owners: rdieter
Branches: F-7 F-8 EL-5
Cvsextras Commits: yes

Comment 8 Kevin Fenzi 2008-02-01 02:28:36 UTC
cvs done.

Comment 9 Fedora Update System 2008-02-01 14:53:15 UTC
libvncserver-0.9.1-2.fc7 has been submitted as an update for Fedora 7

Comment 10 Fedora Update System 2008-02-01 14:53:20 UTC
libvncserver-0.9.1-2.fc8 has been submitted as an update for Fedora 8

Comment 11 Fedora Update System 2008-02-02 01:19:54 UTC
libvncserver-0.9.1-2.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2008-02-02 09:01:47 UTC
libvncserver-0.9.1-2.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Simone Caronni 2014-06-03 08:18:03 UTC
Package Change Request
Package Name: libvncserver
New Branches: epel7
Owners: rdieter slaanesh

Comment 14 Simone Caronni 2014-06-03 08:18:43 UTC
Added libvncserver for epel7 ppc as per policy guidelines:


Comment 15 Gwyn Ciesla 2014-06-03 12:21:07 UTC
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.