Spec URL: http://ianweller.org/rpm/xautolock/xautolock.spec SRPM URL: http://ianweller.org/rpm/xautolock/xautolock-2.2-1.fc8.src.rpm Description: A program that launches a given program when your X session has been idle for a given time.
Hi Ian, I cannot sponsor you, but I can unofficially review your package. rpm was build successfully from srpm and rpmlint didn't complain anything. Your spec file also look fine for me, except the point that you are putting the man file in directory "%{_mandir}/manl" (read man-el), not "man1" (read man-one). Is that intended, or a typo?
i looked at the xautolock man page and it was XAUTOLOCK(l), as in el. so i'm presuming this is correct, and it is intentionally done.
Removing NEEDSPONSOR (bug 417711)
New Package CVS Request ======================= Package Name: flam3 Short Description: Launches a program when your X session has been idle for some time Owners: ianweller Branches: F-7 F-8 InitialCC: ianweller Cvsextras Commits: yes
Crud, I messed up the CVS request. Package Name should read `xautolock'. Here's a new one. New Package CVS Request ======================= Package Name: xautolock Short Description: Launches a program when your X session has been idle for some time Owners: ianweller Branches: F-7 F-8 InitialCC: ianweller Cvsextras Commits: yes
Ah... no, even if you are sponsored, this request must be reviewed by someone. The difference is that as you are sponsored, this review request can be reviewed by non-sponsor members.
OK.
gzip xautolock.man should not be done in the spec, it is done automatically by rpmbuild. Also the permission for man page should be 0644. Man pages are automatically considered %doc. I personally prefer to use globs like %{_mandir}/manl/xautolock.l* to catch all possibility of compression and no compression. The l for man page is a bit strange. Currently on my box all the pages in manl are owned by lapack and blas (and the directory itself is not owned). So it is likely that it is an upstream mistake. It is not an issue for the review, but may be worth asking upstream if there is a typo in the man page.
To install the man page, there is a make target, install.man, and it installs in man1, so it is certainly a typo. I tested that the following works: make install install.man DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" Also for the build, the build flags are not the right ones. I found that the following works: make %{?_smp_mflags} CDEBUGFLAGS="$RPM_OPT_FLAGS" CC=%{__cc} The summary is a bit too long in my opinion, but it is not a blocker.
* Sat Feb 02 2007 Ian Weller <ianweller> 2.2-2 - Shortened summary - Fixed make flags - Fixed installation of man page Spec: http://ianweller.fedorapeople.org/SRPMS/xautolock/2.2-2/xautolock.spec SRPM: http://ianweller.fedorapeople.org/SRPMS/xautolock/2.2-2/xautolock-2.2-2.fc8.src.rpm
koji build ok http://koji.fedoraproject.org/koji/taskinfo?taskID=391426
Source archive timestamp ois not kept: $ ls -l ./xautolock-2.2.tgz ../SOURCES/xautolock-2.2.tgz -rw-r--r-- 1 dumas dumas 35288 jan 27 23:18 ../SOURCES/xautolock-2.2.tgz -rw-rw-r-- 1 dumas dumas 35288 déc 31 23:36 ./xautolock-2.2.tgz You can use wget -N or spectool -g on the spec file. Also the install is now done twice, once in make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" and a second time in make install install.man DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" (when make is given 2 targets, it does both).
whoops. i shoulda seen that... * Sat Feb 02 2007 Ian Weller <ianweller> 2.2-3 - Fixed timestamp of Source0 - Removed redundant installation spec: http://ianweller.fedorapeople.org/SRPMS/xautolock/2.2-3/xautolock.spec srpm: http://ianweller.fedorapeople.org/SRPMS/xautolock/2.2-3/xautolock-2.2-3.fc8.src.rpm
I get a 404 not found....
Is this correct: Group: Applications/Internet I would changed %files lines to: %doc Changelog License Readme Todo %{_bindir}/%{name} %{_mandir}/man1/%{name}.1* but that's me.
(In reply to comment #14) > I get a 404 not found.... fedorapeople.org was down for some reason today, i read it on the mailing list. should work now. (In reply to comment #15) > Is this correct: > Group: Applications/Internet no. fixing. * Sun Feb 03 2008 Ian Weller <ianweller> 2.2-4 - Fixed dates in changelog (2007 -> 2008) - Fixed grouping - Tightened up files list spec: http://ianweller.fedorapeople.org/SRPMS/xautolock/2.2-4/xautolock.spec srpm: http://ianweller.fedorapeople.org/SRPMS/xautolock/2.2-4/xautolock-2.2-4.fc8.src.rpm koji builds: all passed dist-fc7: http://koji.fedoraproject.org/koji/taskinfo?taskID=393437 dist-f8: http://koji.fedoraproject.org/koji/taskinfo?taskID=393430 dist-f9: http://koji.fedoraproject.org/koji/taskinfo?taskID=393442
* rpmlint is silent * free software * follow guidelines * match upstream: 9526347a202694ad235d731d9d3de91f xautolock-2.2.tgz * %files section right APPROVED
New Package CVS Request ======================= Package Name: xautolock Short Description: Launches a program when your X session has been idle Owners: ianweller Branches: F-7 F-8 InitialCC: ianweller Cvsextras Commits: yes
cvs done.
thanks kevin. srpms imported, koji build ok, added to bodhi == NEXTRELEASE ==
pushed to Fedora 7 and 8 stable repos (i forgot to link the bug numbers)
Package Change Request ====================== Package Name: xautolock New Branches: EL-4 EL-5