Red Hat Bugzilla – Bug 430478
Review Request: perl-Authen-Krb5 - perl interface to Kerberos v5 library
Last modified: 2008-01-29 15:17:14 EST
Spec URL: http://homepages.inf.ed.ac.uk/sxw/perl-Authen-Krb5.spec SRPM URL: http://homepages.inf.ed.ac.uk/sxw/perl-Authen-Krb5-1.7-1.fc9.src.rpm Description: Authen::Krb5 is a object oriented perl interface to the Kerberos 5 API
you can use following in %setup instead to create patch1 sed -i 's#/usr/local/bin/perl#/usr/bin/perl#' s*
Done (I've listed the file names explicitly, rather than using a wildcard). Spec URL: http://homepages.inf.ed.ac.uk/sxw/perl-Authen-Krb5.spec SRPM URL: http://homepages.inf.ed.ac.uk/sxw/perl-Authen-Krb5-1.7-2.fc9.src.rpm
Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 41fc7c533b139110557478649eb9e4b2 Krb5-1.7.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + Compiler flags are used correctly. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave nothing + Package perl-Authen-Krb5-1.7-2.fc9 => Provides: Krb5.so perl(Authen::Krb5) = 1.7 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcom_err.so.2 libk5crypto.so.3 libk5crypto.so.3(k5crypto_3_MIT) libkrb5.so.3 libkrb5.so.3(krb5_3_MIT) libresolv.so.2 perl >= 0:5.004 perl(AutoLoader) perl(Carp) perl(DynaLoader) perl(Exporter) perl(strict) perl(vars) rtld(GNU_HASH) APPROVED.
New Package CVS Request ======================= Package Name: perl-Authen-Krb5 Short Description: perl interface to Kerberos v5 library Owners: sxw Branches: F-7 F-8 EL-4 EL-5 InitialCC: Cvsextras Commits:yes
cvs done.
Thanks for the review!