Spec URL: http://fedora.lowlatency.de/review/synce-kpm.spec SRPM URL: http://fedora.lowlatency.de/review/synce-kpm-0.11-1.fc8.src.rpm Description: SynCE-KPM stands for SynCE KDE PDA Manager and aims to be an application to manage WM5/WM6 PDA devices from Linux. This will obsolete synce-kde once rapip is split out of synce-kde (aimed for the 0.12 release of synce).
you missed BR on python-setuptools-devel, build.log gave => ImportError: No module named setuptools
True. I guess BR python-setuptools will be sufficient. http://fedora.lowlatency.de/review/synce-kpm-0.11-2.fc8.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=380581
You need to add Require: libxslt-python. When I installed this on rawhide I see that it required libxslt. when started synce-kpm from terminal got Cannot open file '/usr/lib/python2.5/site-packages/synceKPM/data/lock.svg', becuase: No such file or directory
Should both be fixed now :) http://fedora.lowlatency.de/review/synce-kpm-0.11-3.fc8.src.rpm
Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM. But NOT for RPM. synce-kpm.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/synceKPM/synce_kpm_main.py 0644 ==> Can you fix this? or its needed? synce-kpm.noarch: E: explicit-lib-dependency libxslt-python ==> Ok + source files match upstream. 89d3f7352ddc7bc64a44353466da802e synce-kpm-0.11.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Desktop file handled correctly. + GUI app.
I think the script warning can be discarded but if you want I can set the mode to 755. Judging from other files in the python dir and that it should not be called directly anyway 644 seems sane to me.
(In reply to comment #6) > I think the script warning can be discarded but if you want I can set the mode > to 755. Judging from other files in the python dir and that it should not be > called directly anyway 644 seems sane to me. Ok. keep it 644. APPROVED.
New Package CVS Request ======================= Package Name: synce-kpm Short Description: SynCE KDE PDA Manager Owners: awjb Branches: F-8 Cvsextras Commits: yes
cvs done.
Thanks yet again for another nice review :)