Bug 430578 - Review Request: xmlcopyeditor - A fast, free, validating XML editor
Review Request: xmlcopyeditor - A fast, free, validating XML editor
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Marc Wiriadisastra
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-28 15:56 EST by Ignacio Vazquez-Abrams
Modified: 2008-01-29 16:55 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-29 16:55:15 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
marc: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Ignacio Vazquez-Abrams 2008-01-28 15:56:54 EST
Spec URL: http://ivazquez.fedorapeople.org/packages/xmlcopyeditor/xmlcopyeditor.spec
SRPM URL: http://ivazquez.fedorapeople.org/packages/xmlcopyeditor/xmlcopyeditor-1.1.0.6-2.src.rpm
Description: XML Copy Editor is a fast, free, validating XML editor.
Comment 1 Marc Wiriadisastra 2008-01-28 18:20:43 EST
rpmlint: [marc@Strike-Lap i386]$ rpmlint xmlcopyeditor-*
xmlcopyeditor.i386: W: no-documentation
xmlcopyeditor.i386: W: no-version-in-last-changelog
xmlcopyeditor.i386: W: file-not-in-%lang /usr/share/xmlcopyeditor/po/de/messages.mo
xmlcopyeditor.i386: W: file-not-in-%lang /usr/share/xmlcopyeditor/po/fr/messages.mo
xmlcopyeditor.i386: W: file-not-in-%lang /usr/share/xmlcopyeditor/po/sk/messages.mo
xmlcopyeditor.i386: W: file-not-in-%lang /usr/share/xmlcopyeditor/po/sv/messages.mo
xmlcopyeditor.i386: W: file-not-in-%lang
/usr/share/xmlcopyeditor/po/zh_CN/messages.mo
xmlcopyeditor.i386: W: file-not-in-%lang
/usr/share/xmlcopyeditor/po/zh_TW/messages.mo
xmlcopyeditor-debuginfo.i386: W: spurious-executable-perm
/usr/src/debug/xmlcopyeditor-1.1.0.6/src/pathresolver.h
xmlcopyeditor-debuginfo.i386: W: spurious-executable-perm
/usr/src/debug/xmlcopyeditor-1.1.0.6/src/mypropertysheet.h
xmlcopyeditor-debuginfo.i386: W: spurious-executable-perm
/usr/src/debug/xmlcopyeditor-1.1.0.6/src/xsllocator.h
xmlcopyeditor-debuginfo.i386: W: spurious-executable-perm
/usr/src/debug/xmlcopyeditor-1.1.0.6/src/housestylereader.h
xmlcopyeditor-debuginfo.i386: W: spurious-executable-perm
/usr/src/debug/xmlcopyeditor-1.1.0.6/src/readfile.cpp
xmlcopyeditor-debuginfo.i386: W: spurious-executable-perm 
xmlcopyeditor-debuginfo.i386: W: no-version-in-last-changelog

Lots of rpmlint errors in your package. 

Please add documentation there are some files there with information which
should be included in the %doc section.  

Add this in the files section for the %lang: %files -f %{name}.lang
Add this in the install section for the %lang: %find_lang %{name}
Remove the Requires unless you plan on using it
Lots of permission issues in the debug package please fix those.
Thats it for the moment.
Comment 3 Marc Wiriadisastra 2008-01-29 04:27:22 EST
Desktop file install needs to be altered.
http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755

You don't actually remove the lang files since it is commented out.

The permissions issue's are still there in the debug files.

Your spec file does not match your src.rpm file.  Please upload the correct one.
Comment 4 Marc Wiriadisastra 2008-01-29 04:56:10 EST
- MUST: rpmlint must be run on every package. The output should be posted in the
review. (OK)
- MUST: The package must be named according to the Package Naming Guidelines. (OK)
- MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec (OK)
- MUST: The package must meet the Packaging Guidelines. (OK)
- MUST: The package must be licensed with an open-source compatible license and
meet other legal requirements as defined in the legal section of Packaging
Guidelines. (OK)
- MUST: The License field in the package spec file must match the actual
license. (OK)
- MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. (ok)
- MUST: The spec file must be written in American English. (OK)
- MUST: The spec file for the package MUST be legible.  (OK)
- MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. (OK)
- MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture. (OK)
- MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines; inclusion of
those as BuildRequires is optional. Apply common sense. (OK)
- MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. (OK)
- MUST: A package must not contain any duplicate files in the %files listing. (OK)
- MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. (OK)
- MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT). (OK)
- MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines. (OK)
- MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. (OK)
- MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. (OK)
- MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. (OK)


APPROVED

I won't put a formal Approval till someone more experienced has double checked
what I have done but as far as I'm concerned there is no problems.
Comment 5 Jens Petersen 2008-01-29 05:11:21 EST
Looks fine to me - thanks to the reviewer and submitter.

Might be nice to remove the commented out Requires before importing to cvs.
Comment 6 Marc Wiriadisastra 2008-01-29 05:19:44 EST
Actually not approved sadly.

http://koji.fedoraproject.org/koji/taskinfo?taskID=380883

Fails to build in F-9.
Comment 7 Marc Wiriadisastra 2008-01-29 05:31:09 EST
Actually ignore my previous comment mock failed for me but it turns out it was
just my computer.
Comment 8 Ignacio Vazquez-Abrams 2008-01-29 11:28:59 EST
New Package CVS Request
=======================
Package Name: xmlcopyeditor
Short Description: A fast, free, validating XML editor
Owners: ivazquez
Branches: F-7 F-8
Cvsextras Commits: yes
Comment 9 Kevin Fenzi 2008-01-29 12:51:54 EST
cvs done.
Comment 10 Ignacio Vazquez-Abrams 2008-01-29 16:55:15 EST
Built for F7, F8, and Rawhide.

Note You need to log in before you can comment on or make changes to this bug.