Bug 430848 - libspectre - A library for rendering PostScript(TM) documents
Summary: libspectre - A library for rendering PostScript(TM) documents
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-01-30 05:08 UTC by Matthias Clasen
Modified: 2008-01-30 18:46 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-30 18:46:23 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Matthias Clasen 2008-01-30 05:08:25 UTC
%{name} is a small library for rendering PostScript(TM) documents.
It provides a convenient easy to use API for handling and rendering
PostScript documents.

Spec: http://people.redhat.com/mclasen/libspectre.spec
SRPM: http://people.redhat.com/mclasen/libspectre-0.2.0-1.fc9.src.rpm

Comment 1 Parag AN(पराग) 2008-01-30 05:22:35 UTC
error: Installed (but unpackaged) file(s) found:
/usr/lib/pkgconfig/libspectre.pc

Comment 2 Bill Nottingham 2008-01-30 05:27:53 UTC
Assuming this used to be in evince?

Comment 3 Matthias Clasen 2008-01-30 05:44:04 UTC
Ah, sorry. Forgot to rebuild the srpm with the latest spec file. 

Bill: no, I don't think this is code that was in evince per se, but rather code
that was written by the evince guys, and optionally can be used by evince. Using
it improves the ps support in evince, from what I read - e.g. if you use
libspectre, the dvi backend will support ps specials.

Comment 4 Parag AN(पराग) 2008-01-30 05:45:43 UTC
Can't see any docs installed.
Good to provide tests directory as %doc for -devel package.

Comment 5 Matthias Clasen 2008-01-30 05:48:06 UTC
Better srpm & spec uploaded, same location.

Comment 6 Parag AN(पराग) 2008-01-30 05:59:50 UTC
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=383374
+ rpmlint output on SRPM and for RPM.
libspectre.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 24)
==> Not a problem as its cosmetic message and can be fixed using sed.

+ source files match upstream url
6dc4382d8c9cd355a76c4516f6e6f6e3  libspectre-0.2.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no static libraries.
+ libspectre.pc file present.
+ -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package libspectre-0.2.0-1.fc9 =>
  Provides: libspectre.so.1
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4) libc.so.6(GLIBC_2.7) libgs.so.8 libspectre.so.1 rtld(GNU_HASH)
+ Package libspectre-devel-0.2.0-1.fc9 =>
  Requires: libspectre = 0.2.0-1.fc8 libspectre.so.1 pkgconfig

+ Not a GUI App

APPROVED.

Comment 7 Matthias Clasen 2008-01-30 06:18:03 UTC
New Package CVS Request
=======================
Package Name: libspectre
Short Description: A library for rendering PostScript(TM) documents
Owners: mclasen@redhat.com
Branches: 
InitialCC: 
Cvsextras Commits:


Comment 8 Kevin Fenzi 2008-01-30 17:27:45 UTC
cvs done.

Comment 9 Matthias Clasen 2008-01-30 18:46:23 UTC
package built


Note You need to log in before you can comment on or make changes to this bug.