Red Hat Bugzilla – Bug 430997
tx checksum offload settings reported incorrectly
Last modified: 2014-06-29 18:59:46 EDT
Description of problem:
The TX checksum offload setting for tg3 devices 5755 and 5787 is reported
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Set tx checksum offload by issuing 'ethtool -K ethx tx on'
2. Observe that the tx checksum offload will always be off by issuing
'ethtool -k ethx'.
The bug is in <linux>/net/core/ethtool.c:ethtool_op_get_tx_csum().
< return (dev->features & NETIF_F_IP_CSUM) != 0;
> return (dev->features & (NETIF_F_IP_CSUM | NETIF_F_HW_CSUM)) != 0;
Thanks, Matt. Looks like we need this patch:
Author: Herbert Xu <firstname.lastname@example.org>
Date: Sat Jun 17 22:06:05 2006 -0700
[NET]: Add NETIF_F_GEN_CSUM and NETIF_F_ALL_CSUM
The current stack treats NETIF_F_HW_CSUM and NETIF_F_NO_CSUM
identically so we test for them in quite a few places. For the sake
of brevity, I'm adding the macro NETIF_F_GEN_CSUM for these two. We
also test the disjunct of NETIF_F_IP_CSUM and the other two in various
places, for that purpose I've added NETIF_F_ALL_CSUM.
Signed-off-by: Herbert Xu <email@example.com>
Signed-off-by: David S. Miller <firstname.lastname@example.org>
Actually, the patch in comment #1 is really too much (and not the one that added
the fix). It sounds like just the original fix will resolve this.
We seem to have most of this patch:
but not the part you are requesting (the rest got added during a tg3 update).
I'll get that added.
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release. Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products. This request is not yet committed for inclusion in an Update
My test kernels have been updated to include a patch for this bugzilla.
Please test them and report back your results.
Updating PM score.
Committed in 78.25.EL . RPMS are available at http://people.redhat.com/vgoyal/rhel4/
~~ Attention Partners! Snap 1 Released ~~
RHEL 4.8 Snapshot 1 has been released on partners.redhat.com. There should
be a fix present, which addresses this bug. NOTE: there is only a short time
left to test, please test and report back results on this bug
at your earliest convenience.
If you encounter any issues, please set the bug back to the ASSIGNED state and
describe the issues you encountered. If you have found a NEW bug, clone this
bug and describe the issues you encountered. Further questions can be
directed to your Red Hat Partner Manager.
If you have VERIFIED the bug fix. Please select your PartnerID from the
Verified field above. Please leave a comment with your test results details.
Include which arches tested, package version and any applicable logs.
- Red Hat QE Partner Management
I have verified this issue on kernel 2.6.9-85.EL.gtest.61.
The tx checksum offload function work.
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.