Spec URL: http://ivazquez.fedorapeople.org/packages/ghost-diagrams/ghost-diagrams.spec SRPM URL: http://ivazquez.fedorapeople.org/packages/ghost-diagrams/ghost-diagrams-0.8-1.src.rpm Description: Ghost Diagrams is a program that takes sets of tiles and tries to find patterns into which they may be formed. The patterns it finds when given randomly chosen tiles are often surprising.
--delete-original not needed in desktop-file-install Do you got any icon to install for this desktop file?
Created attachment 293679 [details] Potential icon source (In reply to comment #1) > --delete-original not needed in desktop-file-install Strictly speaking, no. But I'd rather be pedantic about it. > Do you got any icon to install for this desktop file? Nothing official, but I was considering carving one from the attached image generated by it.
(In reply to comment #2) > Created an attachment (id=293679) [edit] > Potential icon source OK > > (In reply to comment #1) > > --delete-original not needed in desktop-file-install > > Strictly speaking, no. But I'd rather be pedantic about it. > Anyway, Not a blocker for review. > > Do you got any icon to install for this desktop file? > > Nothing official, but I was considering carving one from the attached image > generated by it. Ok.
Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream. e578104d433f48639d9cf73aade1ae9e ghost-diagrams-0.8.py + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. - %doc files NOT present. + BuildRequires are proper. + defattr usage is correct + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed correctly. + GUI app. SHOULD: Good if some kind of documentation say README included in next release. APPROVED.
New Package CVS Request ======================= Package Name: ghost-diagrams Short Description: A program that generates patterns from tiles Owners: ivazquez Branches: F-7 F-8 Cvsextras Commits: yes
cvs done.
Closing this as this package has been successfully built for all requested branches on build server.