Bug 431107 - halt script does not work with upstart
Summary: halt script does not work with upstart
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: upstart
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Casey Dahlin
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: upstart
TreeView+ depends on / blocked
 
Reported: 2008-01-31 20:12 UTC by Bill Nottingham
Modified: 2014-06-18 08:46 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-02-17 00:22:10 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
check runlevel in halt/reboot, set --force accordingly (1.15 KB, patch)
2008-02-15 23:03 UTC, Bill Nottingham
no flags Details | Diff

Description Bill Nottingham 2008-01-31 20:12:37 UTC
If you attempt to shutdown/reboot/halt, the halt script just ends up looping
endlessly.

initscripts-8.62-1

Comment 1 Casey Dahlin 2008-02-11 21:29:25 UTC
Have we decided if patching killall5 will work for this?

Comment 2 Bill Nottingham 2008-02-14 21:44:03 UTC
It doesn't loop any more, but it doesn't do the right thing either.

Comment 3 Bill Nottingham 2008-02-15 23:02:20 UTC
This is an upstart bug, at least as far as SysV compatibility goes.

halt/reboot under SysV check the runlevel when they run - if it's 0 or 6
(reboot/halt), then 'force' is implied. upstart's versions don't have that code,
so they just call shutdown again, which starts the loop/hangs.

Patch attached momentarily.

Comment 4 Bill Nottingham 2008-02-15 23:03:27 UTC
Created attachment 295051 [details]
check runlevel in halt/reboot, set --force accordingly

Comment 5 Casey Dahlin 2008-02-16 03:47:16 UTC
Do we want to apply just this patch to upstart, or both this patch and the
no-kill-init sysv patch?

I'll roll this in to the rpm tonight. Scott, care to weigh in?

Comment 6 Scott James Remnant 2008-02-16 11:19:36 UTC
That patch is definitely the right solution ;)

It didn't affect us because our sysv scripts called halt/reboot with --force anyway

Comment 7 Casey Dahlin 2008-02-17 00:22:10 UTC
Well played then :) Rebuilt upstart package is in koji.

We still end up re-executing init on shutdown, but this no longer creates this
issue. I may open another bug about that but for now its no big deal.


Note You need to log in before you can comment on or make changes to this bug.