Bug 431386 - Review Request: rkhunter - A host-based tool to scan for rootkits, backdoors and local exploits
Summary: Review Request: rkhunter - A host-based tool to scan for rootkits, backdoors ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: John Mahowald
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-02-04 01:47 UTC by Kevin Fenzi
Modified: 2008-07-04 19:24 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-07-04 19:24:55 UTC
Type: ---
Embargoed:
jpmahowald: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Kevin Fenzi 2008-02-04 01:47:42 UTC
Spec URL: http://www.scrye.com/~kevin/fedora/rkhunter/rkhunter.spec
SRPM URL: http://www.scrye.com/~kevin/fedora/rkhunter/rkhunter-1.3.0-1.fc9.src.rpm
Description: 

Rootkit Hunter (RKH) is an easy-to-use tool which checks
computers running UNIX (clones) for the presence of rootkits
and other unwanted tools.

This is a re-review of this package, as it's been orphaned for quite some time, 
and I wish to revive it. I have simplified the old spec a great deal and updated it to the latest version. 

This version does not ship the perl scripts for sha1/md5 summing, instead using installed executables, or nothing if they are not installed. Happy to take input on how better to handle this. 

There is also a (rather large) diff against the last spec in cvs at: 
http://www.scrye.com/~kevin/fedora/rkhunter/old-spec.diff

Comment 1 John Mahowald 2008-02-14 09:01:53 UTC
Yay security packages.

Builds on development and runs.

rpmlint:
rkhunter.noarch: E: non-readable /etc/rkhunter.conf 0640
rkhunter.noarch: E: non-readable /etc/sysconfig/rkhunter 0640

Fine, don't let the bad guys read rkhunter config

rkhunter.noarch: W: non-standard-dir-in-var rkhunter
rkhunter.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 30)

Allow.

rkhunter.src: W: strange-permission 01-rkhunter 0755

A script, ignore.



License good, GPLv2+
Source matches
Is noarch
Follows naming guidelines
Proper use of macros
%files section proper permissions, ownership


The perl scripts in the spec are a bit hard to read, but their configuration
purpose is clear.

As to perl scripts for sha1/md5  I agree system executables should be used. In a
rootkit detection situation you may not be able to trust them, which is the only
case I would find those useful. If that's the case I doubt rkhunter would be
much help, as perl and the system is probably untrustworthy anyway.  Feel free
to continue to not include them.


I see cron is using the --update flag. Applying updates will make the db show up
on rpm verification as changed. This might bother the worried user running rpm
-V that their rkhunter is compromised. I don't see any other way of keeping it
updated in between major releases.

Package itself is fine. APPROVED

Comment 2 Kevin Fenzi 2008-02-14 17:57:06 UTC
Thanks for the quick review!

Package Name: rkhunter
Short Description: A host-based tool to scan for rootkits, backdoors and local
exploits
Owners: kevin,devrim
Branches: F-8 F-7
InitialCC: 
Cvsextras Commits: yes


Comment 3 Kevin Fenzi 2008-02-14 22:15:07 UTC
cvs done.

Comment 4 Fedora Update System 2008-03-01 20:45:28 UTC
rkhunter-1.3.2-1.fc8 has been submitted as an update for Fedora 8

Comment 5 Fedora Update System 2008-03-01 21:00:22 UTC
rkhunter-1.3.2-1.fc7 has been submitted as an update for Fedora 7

Comment 6 Fedora Update System 2008-03-03 18:23:42 UTC
rkhunter-1.3.2-1.fc8 has been pushed to the Fedora 8 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rkhunter'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F8/FEDORA-2008-2199

Comment 7 Fedora Update System 2008-03-16 19:28:48 UTC
rkhunter-1.3.2-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2008-03-16 19:29:14 UTC
rkhunter-1.3.2-1.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 John Poelstra 2008-07-04 18:22:34 UTC
can this bug be closed or are you tracking to get update into rawhide?

Comment 10 Kevin Fenzi 2008-07-04 19:24:55 UTC
Nope, we can close it now. 


Note You need to log in before you can comment on or make changes to this bug.