Spec URL: http://kurzawa.nonlogic.org/rpm/gfeed/gfeed.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/gfeed/gfeed-2.5.0-1.fc8.src.rpm Description: gfeed is an RSS feed reader for Linux and Gtk+ 2.0. It is designed to be a simple yet highly customizable reader, not an aggregator, which means it is designed for easy integration into a desktop.
URL: http://sourceforge.net/projects/%{name} is better
Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/gfeed/gfeed.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/gfeed/gfeed-2.5.0-2.fc8.src.rpm
Is icon working for you? I installed rpm and when tried to run gfeed I got options help only. will review this by tomorrow.
Yes icon is working. If you wrote example: "gfeed -f http://linux.pl/rss.php", new windows will open and icon will show. Thanks in advance for review.
SHOULD: 1)Change "%{__install}" to "install" 2)Add doc/out/html/*.html and scripts. But to avoid unnecessary installations of Makefiles in scripts directory, you can add following line to end of %install section rm -f scripts/Makefile* and change %doc to %doc AUTHORS CHANGELOG COPYING README doc/out/html/*.html scripts
Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/gfeed/gfeed.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/gfeed/gfeed-2.5.0-3.fc8.src.rpm P.S If you have time could you also review taskcoach (#430541)?
Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=398563 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 5301287f336599ab77ccba4875993734 gfeed-2.5.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED.
New Package CVS Request ======================= Package Name: gfeed Short Description: RSS feed reader Owners: kurzawa Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Imported and built. Thanks again for review!