Red Hat Bugzilla – Bug 431672
Review Request: scythia - Just a small ftp client
Last modified: 2008-02-08 09:17:56 EST
Spec URL: http://kurzawa.nonlogic.org/rpm/scythia/scythia.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/scythia/scythia-0.9.3-2.1.fc8.src.rpm Description: Scythia project is an simple and portable Ftp client. It does not claim to be able to replace the biggest (no SSH etc.), but only to satisfy some persons and to give us a bigger experience in programming.
1)license is GPLv3+ 2)can it be possible to add GenericName and comment for french also in .desktop like you did for pl_PL
Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/scythia/scythia.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/scythia/scythia-0.9.3-2.2.fc8.src.rpm Thanks for review!
Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=400409 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 2286269b90c84f52463580a271f608b5 scythia_0.9.3-2-src.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + gtk-update-icon-cache scriptlets are used. + Desktop file installed correctly. + GUI app. APPROVED.
New Package CVS Request ======================= Package Name: scythia Short Description: Just a small ftp client Owners: kurzawa Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Imported and built. Thanks again for review!