Bug 432173 - mesa-source contains unconditional selinux references
mesa-source contains unconditional selinux references
Product: Fedora
Classification: Fedora
Component: mesa (Show other bugs)
All Linux
low Severity high
: ---
: ---
Assigned To: Adam Jackson
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2008-02-09 06:42 EST by JW
Modified: 2008-02-18 09:59 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-02-18 09:59:11 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description JW 2008-02-09 06:42:59 EST
Description of problem:
mesa-source contains unconditional selinux references, esp in main/execmem.c

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. try to compile xorg-servers without selinux
Actual results:
execmem.c contains unconditional selinux code (hauled in from mesa package).

Expected results:
meas should not have unconditional selinux code

Additional info:
The question is: should successful compilation of xorg-servers without selinux
be dependent on mesa build without selinux? Probably not.
One fix would be for mesa code to surround the selinux stuff with:
#if defined(WITH_SELINUX) || defined(USE_SELINUX) || defined(WITH_LIBSELINUX)
which would cover most cases (but it is alarming that there is such a variety of
conditionals for selinux ... goodness knows why autoconf stuff doesn't use a
more modular approach - like standard chunks of configure.ac to include).
The other solution would be for xorg-servers to link with a pre-compiled mesa
library which is the normal way to do things (rather than copy the mesa source
Comment 1 Adam Jackson 2008-02-18 09:58:57 EST
This is fixed in 7.1-0.11 and later.  Admittedly, that's not built into rawhide
yet, but it will be just as soon as the buildsystem comes back up.

Note You need to log in before you can comment on or make changes to this bug.