Bug 432173 - mesa-source contains unconditional selinux references
Summary: mesa-source contains unconditional selinux references
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: mesa
Version: 8
Hardware: All
OS: Linux
low
high
Target Milestone: ---
Assignee: Adam Jackson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-02-09 11:42 UTC by JW
Modified: 2008-02-18 14:59 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-02-18 14:59:11 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description JW 2008-02-09 11:42:59 UTC
Description of problem:
mesa-source contains unconditional selinux references, esp in main/execmem.c

Version-Release number of selected component (if applicable):
mesa-source-7.0.1-7

How reproducible:
Always

Steps to Reproduce:
1. try to compile xorg-servers without selinux
  
Actual results:
execmem.c contains unconditional selinux code (hauled in from mesa package).

Expected results:
meas should not have unconditional selinux code

Additional info:
The question is: should successful compilation of xorg-servers without selinux
be dependent on mesa build without selinux? Probably not.
One fix would be for mesa code to surround the selinux stuff with:
#if defined(WITH_SELINUX) || defined(USE_SELINUX) || defined(WITH_LIBSELINUX)
which would cover most cases (but it is alarming that there is such a variety of
conditionals for selinux ... goodness knows why autoconf stuff doesn't use a
more modular approach - like standard chunks of configure.ac to include).
The other solution would be for xorg-servers to link with a pre-compiled mesa
library which is the normal way to do things (rather than copy the mesa source
code).

Comment 1 Adam Jackson 2008-02-18 14:58:57 UTC
This is fixed in 7.1-0.11 and later.  Admittedly, that's not built into rawhide
yet, but it will be just as soon as the buildsystem comes back up.


Note You need to log in before you can comment on or make changes to this bug.