Bug 432186 - hpricot won't build with ragel 6.0
Summary: hpricot won't build with ragel 6.0
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: rubygem-hpricot
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-02-09 14:57 UTC by Mamoru TASAKA
Modified: 2009-02-11 04:15 UTC (History)
2 users (show)

Fixed In Version: 0.6.164-3.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-02-11 04:15:56 UTC


Attachments (Terms of Use)
Patch to hpricot-0.6 rakefile so ragel is not run less .rl file is altered. (1.65 KB, patch)
2008-02-11 00:48 UTC, Jeremy Hinegardner
no flags Details | Diff

Description Mamoru TASAKA 2008-02-09 14:57:17 UTC
Description of problem:
As we are requested to build packages against gcc43,
I tried to rebuild ruby-hpricot.
However rebuild of ruby-hpricot fails with ragel 0.6.
http://koji.fedoraproject.org/koji/taskinfo?taskID=408187

When I download ragel to 5.25-2.fc9 rebuild succeeds even
with gcc43.

Jeremy, honestly saying I am not familiar with ragel.
Would you help me fixing hpricot (if something is wrong with
hpricot)?

Version-Release number of selected component (if applicable):
ruby-hpricot-0.6-1.fc9
ragel-6.0-1.fc9

How reproducible:
100%

Steps to Reproduce:
1. Try to rebuild ruby-hpricot

  
Actual results:
Rebuild fails

Additional info:
With ragel-5.25-2.fc9 rebuild is okay

Comment 1 Jeremy Hinegardner 2008-02-11 00:46:21 UTC
ruby-hpricot should require ragel to build.  The ragel generated .c and .java
file ships with hpricot.  It looks like it is a bug in the rakefile that causes
ragel to get run for every compile, when it doesn't need to.

ragel has changed some of its command line options in 6.0 and the main 'ragel'
command now does both the front and the backend jobs.  So there is no need to |
to rlgen-cd and such.

But it also looks like hpricot's .rl files are not good for ragel 6.0 in any
case.    

That makes 2 upstream bugs to file.  One for the rakefile running ragel every
time( when building from .tgz), and another for the .rl files not working with
ragel 6.0.

I have attached a Rakefile patch to the hpricot-0.6 distribution that should
allow you to remove ragel as a build dependency for hpricot.  I'll send this
patch upstream (http://code.whytheluckystiff.net/hpricot/report) if you want to
also file a bug with them that says that hpricot doesn't build with ragel 6.0

Comment 2 Jeremy Hinegardner 2008-02-11 00:48:05 UTC
Created attachment 294528 [details]
Patch to hpricot-0.6 rakefile so ragel is not run less .rl file is altered.

Comment 3 Jeremy Hinegardner 2008-02-11 01:13:10 UTC
upstream for running ragel filed :
http://code.whytheluckystiff.net/hpricot/ticket/142

upstream for failure to work with ragel filed :
http://code.whytheluckystiff.net/hpricot/ticket/143

Comment 4 Mamoru TASAKA 2008-02-12 15:53:43 UTC
Jeremy, thank you for analyzing hpricot, writing a patch and
filing bugs on upstream!

Now with your patch hpricot successfully builds with ragel 6.0+.
http://koji.fedoraproject.org/koji/taskinfo?taskID=419127

I will keep track of upstream bugs. I want to keep this bug open 
unless upstream reacts to the bugs you filed.

Comment 5 Bug Zapper 2008-05-14 05:06:49 UTC
Changing version to '9' as part of upcoming Fedora 9 GA.
More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 6 Mamoru TASAKA 2009-02-11 04:15:56 UTC
Fixed in rubygem-hpricot-0.6.164-3.fc11, thank you.


Note You need to log in before you can comment on or make changes to this bug.