Spec URL: http://liviopl.fedorapeople.org/disk-manager/disk-manager.spec SRPM URL: http://liviopl.fedorapeople.org/disk-manager/disk-manager-latest.src.rpm Description: Disk manager is a simple filesystem configurator that allows you to: * automatically detect new partitions at startup; * fully manage configuration of filesystem; * Enable/disable write support for NTFS.
Please note that according to the headers of the files available at http://codebrowse.launchpad.net/~givre/disk-manager/trunk/files/flomertens%40gmail.com-20070716195847-5f86mlx0ufug68fo?file_id=diskmanager-20070411132806-a0qdn4eststnd1g7-1, the correct license is GPLv2+ (despite a couple of files being LGPL)
So, "GPLv2+ or LGPL" or "GPLv2+" should be in license tag?
GPLv2+ and LGPL (with appropriate version). Then put a comment explaining which files are under LGPL.
Spec URL: http://liviopl.fedorapeople.org/disk-manager/disk-manager.spec SRPM URL: http://liviopl.fedorapeople.org/disk-manager/disk-manager-latest.src.rpm Fixed
There seems to be a small error in the file list. My mock build failed with: Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/disk-manager-1.0.1-2.fc9-root-mockbuild RPM build errors: File not found by glob: /var/tmp/disk-manager-1.0.1-2.fc9-root-mockbuild/etc/pam.d/* File not found by glob: /var/tmp/disk-manager-1.0.1-2.fc9-root-mockbuild/etc/security/console.apps/* EXCEPTION: Command failed. See logs for output. # bash -l -c 'rpmbuild -bb --target x86_64 --nodeps //builddir/build/SPECS/disk-manager.spec' Traceback (most recent call last): File "/usr/lib/python2.5/site-packages/mock/trace_decorator.py", line 70, in trace result = func(*args, **kw) File "/usr/lib/python2.5/site-packages/mock/util.py", line 286, in do raise mock.exception.Error, ("Command failed. See logs for output.\n # %s" % (command,), ret) Error: Command failed. See logs for output.
Give me the logs. I can't say what's wrong for you.
Actually this does not build. http://koji.fedoraproject.org/koji/taskinfo?taskID=411762 You can check if your srpm builds on koji by: $ koji build --scratch <target> <srpm_you_want_to_try> Currently <target> can be dist-f9, dist-f8-updates-candidate, or dist-fc7-updates-candidate (and some special targets). If the scratch build is successful, the rebuilt rpms and some logs are put under: http://koji.fedoraproject.org/scratch/<your_FAS_name>/task_<task_id>/
> There seems to be a small error in the file list. It can't be an error, because disk-manager provides few files over there. > checking for consolehelper... no > checking for modprobe... no > checking for mount... no > checking for umount... no > checking for blkid... no > checking for dmsetup... no Error... Missing dependency for usermode and... util-linux-ng, e2fsprogs, device-mapper. -- Spec URL: http://liviopl.fedorapeople.org/disk-manager/disk-manager.spec SRPM URL: http://liviopl.fedorapeople.org/disk-manager/disk-manager-latest.src.rpm Should work now.
LGPLv2.1+ is not a correct value for the license tag; according to http://fedoraproject.org/wiki/Licensing#head-19fc3ef10add085a28cb06784dc34ef8b05a9bd6 the correct value is LGPLv2+ The Categories tag from the desktop file should not contain Application any more ( see http://standards.freedesktop.org/menu-spec/latest/apa.html , referenced by http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755) Some minor issues: - there is no need to included util-linux-ng as BR because it is on the exceptions list (http://fedoraproject.org/wiki/Packaging/Guidelines#head-4cadce5e79d38a63cad3941de1dadc9d25d67d30-2) - duplicate BR: perl(XML::Parser) is brought in by intltool and device-mapper by e2fsprogs Everything else seems OK at the first glance
Spec URL: http://liviopl.fedorapeople.org/disk-manager/disk-manager.spec SRPM URL: http://liviopl.fedorapeople.org/disk-manager/disk-manager-latest.src.rpm Fixed.
I'm only not sure if I should use desktop-file-install for .desktop file in /etc.
CANCEL
Reopening, as I cancelled migrating to other distro. Sorry for messing.
So exactly whats happening here? Is there any review request here or just discussion happening?
http://liviopl.fedorapeople.org/disk-manager/disk-manager.spec is 404 error: Not Found.