Spec URL: http://kurzawa.nonlogic.org/rpm/pic2aa/pic2aa.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/pic2aa/pic2aa-0.2.1-1.fc8.src.rpm Description: Pic2AA is tool providing converting jpeg/png (and any other image formats supported by Qt library) to AA (Ascii Art) images, using AA-Lib library. It can show preview of converted image and save image into text file.
I'm not sponsored so I can't approve this, but from what I can see it meets every requirement. The only changes I would make are that the word 'providing' should be replaced with 'for' in the summary and description, and 'preview' should be 'previews', also in the description. Source file match upstream: YES Package meets versioning and naming guidelines: YES Specfile is properly named, is cleanly written and uses macros consistently: YES Dist tag is present: YES Build root is correct: YES License field matches the actual license: YES License is open source-compatible: YES Latest version is being packaged: YES BuildRequires are proper: YES Compiler flags are appropriate: YES %clean is present: YES Package installs properly debuginfo package looks complete: YES rpmlint is silent: YES Final provides and requires are sane: YES %check is present and all tests pass: YES No shared libraries are added to the regular linker search paths: YES Owns the directories it creates: YES Doesn't own any directories it shouldn't: YES No duplicates in %files: YES File permissions are appropriate: YES No scriptlets present: YES Code, not content: YES Documentation is small, so no -docs subpackage is necessary: YES No headers: YES No pkgconfig files: YES No libtool .la droppings: YES
Further to the above: Forgot to mention that rpmlint is complaining about: pic2aa.i386: W: file-not-utf8 /usr/share/doc/pic2aa-0.2.1/COPYING pic2aa.i386: W: file-not-utf8 /usr/share/doc/pic2aa-0.2.1/AUTHORS on the binary RPM. Also, after a conversation in #fedora-devel, I think that specspo handles translations, so I'm not sure if these should be in the spec.
You can use iconv to convert it into UTF-8 Example: %prep iconv --from=ISO-8859-1 --to=UTF-8 file.txt > file.txt.utf8 mv file.txt.utf8 file.txt
Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/pic2aa/pic2aa.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/pic2aa/pic2aa-0.2.1-2.fc8.src.rpm Thanks for review and thanks for help!
Benjamin, Thanks for having a look at this package and your review. But, I see that "Fedora user tc1415, aka Benjamin Tomos Lewis <ben.lewis.uk> has requested membership in the cvsextras group and needs a sponsor." So, its good to review other's packages but you fist get sponsorship and then start changing fedora-review flags. removing fedora-review+ and taking this for review.
1)I see that timestamp of upstream tarball is preserved. upstream tarball -> -rw-r--r-- 1 parag parag 156379 2005-02-15 17:42 pic2aa-0.2.1.tar.gz tarball in SRPM -> -rw-rw-r-- 1 parag parag 156379 2008-02-10 15:10 pic2aa-0.2.1.tar.gz 2) Change comment in desktop file to what new summary is now. 3)So you took screenshot posted on upstream web site as icon. Not sure if there will be any licensing issue for using that screenshot as icon for desktop. But looks ok as upstream is not providing any desktop file and icon file and to use that screenshot as icon file. 4) Can you add comment in PL language also in .desktop file?
Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/pic2aa/pic2aa.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/pic2aa/pic2aa-0.2.1-3.fc8.src.rpm
Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=422141 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 8c0431aa6521f6abc55459cb9d6e70f8 pic2aa-0.2.1.tar.gz d3b0b6f745e6137bd6fb54164e284dcf shot1.png + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Desktop file installed correctly. + GUI app. Should: Issue 1 from comment #1 still exists. Fix that. APPROVED.
Could you explain me what should I fix?
New Package CVS Request ======================= Package Name: pic2aa Short Description: Pic2AA is tool for converting jpeg/png to AA (Ascii Art) images Owners: kurzawa Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
(In reply to comment #9) > Could you explain me what should I fix? download source tarball using wget and just package it in SRPM.
Imported and built. Thanks again for review!