Spec URL: http://sandeen.fedorapeople.org/ffsb/ffsb.spec SRPM URL: http://sandeen.fedorapeople.org/ffsb/ffsb-5.2.1-1.fc8.src.rpm Description: The Flexible Filesystem Benchmark (FFSB) is a cross-platform filesystem performance measurement tool. It uses customizable profiles to measure of different workloads, and it supports multiple groups of threads across multiple filesystems.
+ is OK - is Need work Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=421570 + rpmlint is silent for SRPM and for RPM. + source files match upstream. b58c515d990886cab69b7d9b726536cd ffsb-5.2.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. - Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. SHOULD: 1)Use macros in %files section also. use %{_bindir} 2)you can use defattr as defattr(-,root,root,-) I am waiting for koji build to finish to see it builds on all archs.
oops. I changed flag to fedora-review+ before koji build finishes.
> 1)Use macros in %files section also. use %{_bindir} oops meant to; quickly put in /usr/bin/ because I couldn't remember the macro name :) Will fix those up. Thanks! -Eric
updated files posted at same urls.
Koji was sad but now building: http://koji.fedoraproject.org/koji/taskinfo?taskID=421883
thanks for the build APPROVED.
Thanks for the quick review! New Package CVS Request ======================= Package Name: ffsb Short Description: The Flexible Filesystem Benchmark Owners: sandeen Branches: F-8 InitialCC: Cvsextras Commits: yes
cvs done.
All set, thanks!