Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://www.normalesup.org/~rineau/Fedora/figtoipe.spec SRPM URL: http://www.normalesup.org/~rineau/Fedora/figtoipe-20071004-3.fc9.src.rpm Description: Figtoipe is a program that reads FIG files (as generated by xfig) and generates an XML file readable by the Ipe editor. Note #1: That tool was previously shipped with the Ipe editor itself. From ipe-6.0pre30, figtoipe is released in another tarball. Maybe I should add a field "Obsoletes: ipe < 6.0-0.23.pre30". I am not used to the semantic of Obsoletes: and I am not sure of that. What do you think? Note #2: the spec file is really simple. No call to configure or make. Just one call to g++, and a manual installation. I use perl to extract a changelog from the .cpp file. That way I can make it a %doc.
Well, the BR needs to be zlib-devel, not zlib. Also, I'd like to see a copy of the license in the final package. * source files match upstream: ea0d1ff62c7c342450fdb0676a2b6192 figtoipe-20071004.tar.gz ea0d1ff62c7c342450fdb0676a2b6192 figtoipe-20071004.tar.gz.new * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * license field matches the actual license. * license is open source-compatible. XXX License text not included in package. * latest version is being packaged. X BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock ( ). * package installs properly * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app.
Update (figtoipe-20071004-4.fc9): http://www.normalesup.org/~rineau/Fedora/figtoipe.spec http://www.normalesup.org/~rineau/Fedora/figtoipe-20071004-4.fc9.src.rpm (In reply to comment #1) > Well, the BR needs to be zlib-devel, not zlib. %-S Sorry for that stupid error. My laptop is too short in free space today to run mock. > Also, I'd like to see a copy of the license in the final package. I have added a copy of http://www.gnu.org/licenses/gpl-2.0.txt Maybe should I add a copy of the GPLv3, as the licensing is GPLv2+ (with an exception for CGAL).
(In reply to comment #2) > I have added a copy of http://www.gnu.org/licenses/gpl-2.0.txt > Maybe should I add a copy of the GPLv3, as the licensing is GPLv2+ (with an > exception for CGAL). > I really meant the license information from the top of the .cpp file so that people know what the exception is - though it doesn't apply in this case.
Ping?
Update (figtoipe-20071004-4.fc10): http://www.normalesup.org/~rineau/Fedora/figtoipe.spec http://www.normalesup.org/~rineau/Fedora/figtoipe-20071004-5.fc10.src.rpm Sorry Orion, because of my daily job (too busy in February) I forgot that package submission! Here is an update, in respond to your suggestion in comment #3. %changelog * Fri May 16 2008 Laurent Rineau <laurent.rineau__fedora> - 20071004-5 - Add a copy of the figtoipe.cpp header in license.txt
Looks good, but it also looks like a new version (20080505) is available from upstream.
Update: http://www.normalesup.org/~rineau/Fedora/figtoipe.spec http://www.normalesup.org/~rineau/Fedora/figtoipe-20080505-1.fc10.src.rpm You are right. Upstream has not announced it on the mailing list. Upstream tarball changed "readme.txt" to "README". I have changed the name of the generated files "CHANGES" and "LICENSE" accordingly.
You don't need to gzip the man page, that is done automatically. -- figtoipe.spec 2008-05-17 11:12:35.000000000 -0600 +++ figtoipe.spec.new 2008-05-19 10:31:09.000000000 -0600 @@ -12,7 +12,7 @@ Source0: http://luaforge.net/frs/download.php/3343/figtoipe-%{version}.tar.gz Source1: http://www.gnu.org/licenses/gpl-2.0.txt BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) -BuildRequires: zlib-devel, gzip, perl +BuildRequires: zlib-devel, perl %description Figtoipe is a program that reads FIG files (as generated by @@ -39,7 +39,6 @@ install -m 755 figtoipe $RPM_BUILD_ROOT%{_bindir} mkdir -p $RPM_BUILD_ROOT%{_mandir}/man1 install -m 644 figtoipe.1 $RPM_BUILD_ROOT%{_mandir}/man1 -gzip $RPM_BUILD_ROOT%{_mandir}/man1/figtoipe.1 %clean rm -rf $RPM_BUILD_ROOT @@ -49,7 +48,7 @@ %defattr(-,root,root,-) %doc README CHANGES gpl-2.0.txt LICENSE %{_bindir}/figtoipe -%{_mandir}/man1/figtoipe.1.gz +%{_mandir}/man1/figtoipe.1* %changelog * Sat May 17 2008 Laurent Rineau <laurent.rineau__fedora> - 20080505-1
Update: http://www.normalesup.org/~rineau/Fedora/figtoipe.spec http://www.normalesup.org/~rineau/Fedora/figtoipe-20080505-2.fc10.src.rpm You are right. I forgot to have a look at the rpm scripts. New release, with your patch, but the last line (I avoid glob in %files).
Looks good. APPROVED.
Dear cvs admins, New Package CVS Request ======================= Package Name: figtoipe Short Description: FIG to IPE conversion tool Owners: rineau Branches: F-8 F-9
Laurent - What I don't understand - figtoipe is already in the ipe package. Why the separate package.
ipe-6.0pre30 (the last upstream version, already in F-9 and Rawhide) no longer has figtoipe included. When I saw that missing, I first planned to make figtoipe reviewed before the F-9 freeze. But my daily job got more difficult in February (and then I forgot that review request :-$ ). I want to update ipe to ipe-6.0pre30 in F-8 also, that is why i request a F-8 branch for figtoipe.
The current version of ipe in F-9 and Rawhide is ipe-6.0-0.25.pre30%{?dist}. Maybe I will update all ipe versions in F-8, F-9 and rawhide to ipe-6.0-0.26.pre30%{?dist} and add: Obsoletes: ipe < ipe-6.0-0.26.pre30%{?dist} to figtoipe. That way, F-9 and rawhide users will recover that missing /usr/bin/figtoipe that disappeared during the upgrade to F-9, and F-8 users will upgrade smoothly to the new release of ipe.
cvs done.
I'm closing since a rawhide build has been done.