Bug 433110 - Review Request: python-tidy - Python wrapper for tidy, from the HTML tidy project
Review Request: python-tidy - Python wrapper for tidy, from the HTML tidy pr...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jan ONDREJ
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-16 08:24 EST by Terje Røsten
Modified: 2008-02-17 13:48 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-02-17 13:48:38 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
ondrejj: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Terje Røsten 2008-02-16 08:24:40 EST
Spec URL: http://terjeros.fedorapeople.org/python-tidy/python-tidy.spec
SRPM URL: http://terjeros.fedorapeople.org/python-tidy/python-tidy-0.2-1.src.rpm
Description:
Python wrapper (bindings) for tidylib, this allows you to tidy HTML
files through a Pythonic interface.
Comment 1 Jan ONDREJ 2008-02-17 02:44:51 EST
BLOCKER: There is a mix of licenses for source package. You chosen wrong license
for this package. Please, be careful when setting package license tags.

BLOCKER: Package does not match package-naming-guidelines. Your package is named
python-tidy and upstream package uTidylib. I see, that you are using just one
part from this source, but I don't know, if we can mix that this way.

BLOCKER: python-tidy.noarch: E: explicit-lib-dependency libtidy
Add version info for libtidy requirement.

Other comments:
I think a better group for this package is Development/Languages .

Add version for python-devel. uTidylib requires python>=2.3

This code is not required:
%{python_sitelib}/tidy
%if 0%{?fedora} >= 9
%{python_sitelib}/%{oname}-%{version}-py%{pyver}.egg-info

You can use %{python_sitelib}/*

As I don't know, what to do with this license mix, I can't approve you package
now. If you can give me a link to more information.

You can ask author to remove path.py from this package and rename it's package
as you need. Otherwise you need to fix these problems.
Comment 2 Terje Røsten 2008-02-17 05:31:40 EST
(In reply to comment #1)
> BLOCKER: There is a mix of licenses for source package. You chosen wrong license
> for this package. Please, be careful when setting package license tags.

Fixed.
 
> BLOCKER: Package does not match package-naming-guidelines. Your package is named
> python-tidy and upstream package uTidylib. I see, that you are using just one
> part from this source, but I don't know, if we can mix that this way.

The name is correct (as I read this, make most sense too:

 http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-8756a3bce652c376d7ba3908461b638784b6952d
 
> BLOCKER: python-tidy.noarch: E: explicit-lib-dependency libtidy
> Add version info for libtidy requirement.

Fixed.

> Other comments:
> I think a better group for this package is Development/Languages .

php-tidy is using that, ok.

> Add version for python-devel. uTidylib requires python>=2.3

fixed

> This code is not required:
> %{python_sitelib}/tidy
> %if 0%{?fedora} >= 9
> %{python_sitelib}/%{oname}-%{version}-py%{pyver}.egg-info
> 
> You can use %{python_sitelib}/*

Both are valid, %if is safer when things changes, but ...
 
> As I don't know, what to do with this license mix, I can't approve you package
> now. If you can give me a link to more information.
> 
> You can ask author to remove path.py from this package and rename it's package
> as you need. Otherwise you need to fix these problems.

See the fix, it's normal to have several licenses on a package.


spec: http://terjeros.fedorapeople.org/python-tidy/python-tidy.spec
srpm: http://terjeros.fedorapeople.org/python-tidy/python-tidy-0.2-2.src.rpm



Comment 3 Jan ONDREJ 2008-02-17 06:09:11 EST
(In reply to comment #2)
> (In reply to comment #1)
> > BLOCKER: There is a mix of licenses for source package. You chosen wrong license
> > for this package. Please, be careful when setting package license tags.
> 
> Fixed.

Not fixed. Where do you see "BSD" in licenses? There is just one LICENSE file
which contain MIT license.

> The name is correct (as I read this, make most sense too:
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-8756a3bce652c376d7ba3908461b638784b6952d

OK, accepting this.

> > Add version for python-devel. uTidylib requires python>=2.3
> 
> fixed

If you are using Requires: python >=2.5, set same version for python-devel

> See the fix, it's normal to have several licenses on a package.

On IRC guys told me, that public domain do not need to be mentioned here.
Just fix the "BSD" to "MIT". You can mention other licenses in comments of .spec
file.
Comment 4 Terje Røsten 2008-02-17 07:34:23 EST
> Not fixed. Where do you see "BSD" in licenses? There is just one LICENSE file
> which contain MIT license.

Better now?
 

> If you are using Requires: python >=2.5, set same version for python-devel

Ok.
 
> On IRC guys told me, that public domain do not need to be mentioned here.
> Just fix the "BSD" to "MIT". You can mention other licenses in comments of
.spec file.
 
Here we go:

spec: http://terjeros.fedorapeople.org/python-tidy/python-tidy.spec
srpm: http://terjeros.fedorapeople.org/python-tidy/python-tidy-0.2-3.src.rpm

Comment 5 Jan ONDREJ 2008-02-17 09:39:04 EST
Much better. :-)

APPROVED.

Do not require EL-* builds, because there are no python-2.5 for this OS.

Please, be careful when setting license fields in future.
Comment 6 Terje Røsten 2008-02-17 10:06:27 EST
> Much better. :-)
> 
> APPROVED.

Thanks!


New Package CVS Request
=======================
Package Name: python-tidy
Short Description: Python wrapper for tidy, from the HTML tidy project
Owners: terjeros
Branches: F-7 F-8
InitialCC:
Cvsextras Commits: yes




Comment 7 Kevin Fenzi 2008-02-17 12:31:55 EST
cvs done.
Comment 8 Terje Røsten 2008-02-17 13:48:38 EST
Built and pushed for rawhide, f7 and f8.

Note You need to log in before you can comment on or make changes to this bug.