Spec URL: http://downloads.sourceforge.net/anyremote/anyremote-fedora.spec?use_mirror=osdn http://downloads.sourceforge.net/anyremote/kanyremote-fedora.spec?use_mirror=osdn http://downloads.sourceforge.net/anyremote/ganyremote-fedora.spec?use_mirror=osdn SRPM URL: http://downloads.sourceforge.net/anyremote/anyremote-4.3-1.fc8.src.rpm?use_mirror=osdn http://downloads.sourceforge.net/anyremote/kanyremote-4.5-1.fc8.src.rpm?use_mirror=osdn http://downloads.sourceforge.net/anyremote/ganyremote-2.6-1.fc8.src.rpm?use_mirror=osdn Description: The overall goal of this project is to provide remote control service on Linux through Bluetooth, InfraRed, Wi-Fi or TCP/IP connection. anyRemote supports wide range of modern cell phones like Nokia, SonyEricsson, Motorola and others. anyRemote was developed as thin "communication" layer between Buetooth (IR, Wi-Fi)-capabled phone and Linux, and in could be configured to manage almost any software. gAnyRemote and kAnyRemote are GTK and KDE GUI frontends for anyRemote. This is my first package and i need a sponsor.
Hi, this is an informal review, I can't approve your package or sponsor you. [-] Don't use %define for name and version [-] Summary should'n end with a dot [-] Group Applications/Telephony doesn't exist, use one of the groups in cat /usr/share/doc/rpm*/GROUPS [-] Source tag should contain a link to the original tarball: Source0: http://downloads.sourceforge.net/anyremote/anyremote-4.3.tar.gz [-] Recommended Buildroot is %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) [-] Don't require coreutils, binutils, bash, gawk, bc, uucp, bluez-utils, bluez-libs, libXtst. RPM will find them itself. [-] Add libdir to configure script: ./configure --libdir=%{_libdir}
First of all, please submit submit one review request for one package. i.e. for {k,g}anyremote, please submit other review requests and set bug dependency properly.
OK. Corrected *spec and *src.rpm are here: Spec URL: http://downloads.sourceforge.net/anyremote/anyremote-fedora.spec?use_mirror=osdnSRPM URL: http://downloads.sourceforge.net/anyremote/anyremote-4.3-2.fc8.src.rpm?use_mirror=osdn 2 Guidolin Francesco: I agree with comments (and already corrected tham) except: > Don't use %define for name and version Are You serious ? Using of %{name} is clearly specified at http://fedoraproject.org/wiki/Packaging/Guidelines > Add libdir to configure script: i do not think it is necessary, since i've run configure with --prefix=... and this is implies --libdir=... > Don't require coreutils, binutils, bash, gawk, bc, uucp In general this is true. But not in this case, because RPM will _not_ find them.
2 Mamoru Tasaka: Bug 433219: Review Request: ganyremote - GTK frontend for anyremote Bug 433220: Review Request: kAnyREmote - KDE frontend for anyremote
OK
>Are You serious ? Using of %{name} is clearly specified at >http://fedoraproject.org/wiki/Packaging/Guidelines Right, but you don't need to write: %define name anyremote %define version 4.3 Name: %{name} Version: %{version} You can write directly: Name: anyremote Version: 4.3 and use %{name} in the rest of the spec file without using %define Name and %define Version.
(In reply to comment #7) > Right, but you don't need to write: > %define name anyremote Wow...it works ) Thank You for the advice ! Corrected *spec and *src.rpm are here: Spec URL: http://downloads.sourceforge.net/anyremote/anyremote-fedora.spec?use_mirror=osdn SRPM URL: http://downloads.sourceforge.net/anyremote/anyremote-4.3-2.fc8.src.rpm?use_mirror=osdn
Well, * Why do you want to split -data, -doc subpackages although anyremote requires those subpackages? * Please remove Redundant Requires/BuildRequires - Why do you want to write the following Requires? coreutils binutils (is binutils really needed?) bash gawk bc (is bc really needed?) uucp (is uucp really needed?) - Requires: bluez-libs should be removed. These library dependency should be automatically added to binary rpms by rpmbuild. * Also please remove redundant BuildRequires. - gcc - glibc-headers - make (please check "Exceptions" of http://fedoraproject.org/wiki/Packaging/Guidelines ) * On the other hands, at least some BuildRequries are missing. http://koji.fedoraproject.org/koji/taskinfo?taskID=466056 * Please consider to use %configure (check what %configure does by $ rpm --eval %configure) * Stripping the rebuilt binaries by yourself is forbidden to create -debuginfo rpm correctly * For man files, please use %{_mandir}/ * Please make it sure that all directories created when installing a rpm are owned by the rpm. For example, the directory %{_datadir}/%{name} is not owned by any package. * Document files should usually be installed under %{_defaultdocdir}/%{name}-%{version}, not %{_datadir}/%{name}. * To make it sure that all installed files are correctly built from open source files, we do not allow to install pre-compiled files (like .jar files) directly. So - If .jar files are needed, please rebuild it from sources. - Otherwise please don't install .jar files.
(In reply to comment #9) >* Why do you want to split -data, -doc subpackages ? To have possibility release them separately. (for example: if only -data package was changed) > Please remove Redundant Requires/BuildRequires OK. Done except bc. bc is not covered by "exception" list. > is bc really needed? Yes >Also please remove redundant BuildRequires. OK. Done. >On the other hands, at least some BuildRequries are missing. OK. libXtst-devel was added. >Please consider to use %configure (check what %configure does OK. Done. >Stripping the rebuilt binaries by yourself is forbidden to create OK. Done. >For man files, please use %{_mandir}/ OK. Done. >Please make it sure that all directories created when installing a rpm are owned by the rpm. OK. Done. >Document files should usually be installed under %{_defaultdocdir}/%{name}-%{version}, not %{_datadir}/%{name}. OK. %{_datadir}/%{name} changed to %{_defaultdocdir}/%{name} >To make it sure that all installed files are correctly built from open source files, we do not allow to install pre-compiled files (like .jar files) directly. It is written in packaging/Guidlines: : Some software (usually related to compilers or cross-compiler : environments) cannot be build without the use of a previous toolchain : or development environment (open source). If you have a package which meets : this criteria, contact the Fedora Packaging Committee for approval. To build *jar i use Sun WTK, which can be considered as "toolchain", but it is not open source at all. I need an advice, how it is possible to distribute *jar anyway (Livna ?) because without *jar this project will be almost unuseful.
Updated: Spec URL: http://downloads.sourceforge.net/anyremote/anyremote-fedora.spec?use_mirror=osdn SRPM URL: http://downloads.sourceforge.net/anyremote/anyremote-4.3-3.fc8.src.rpm?use_mirror=osdn
(In reply to comment #10) > (In reply to comment #9) > >To make it sure that all installed files are correctly built from > open source files, we do not allow to install pre-compiled files > (like .jar files) directly. > It is written in packaging/Guidlines: > : Some software (usually related to compilers or cross-compiler > : environments) cannot be build without the use of a previous toolchain > : or development environment (open source). If you have a package which meets > : this criteria, contact the Fedora Packaging Committee for approval. > To build *jar i use Sun WTK, which can be considered as "toolchain", but > it is not open source at all. I need an advice, how it is possible to > distribute *jar anyway (Livna ?) because without *jar this project will be > almost unuseful. Isn't is possible to build jar files in this package by using java related packages provided by Fedora? As far as I know most Fedora java packages use ant to rebuild jar files.
> Isn't is possible to build jar files in this package by using > java related packages provided by Fedora? As far as I know > most Fedora java packages use ant to rebuild jar files. No. This *jar is not for J2SE, but for J2ME (midlet, which should be installed in cell phone). Seems, it is a good question for Fedora Packaging Committee, since (IMHO) all midlets are depends from Sun WTK or Nokia/Motorola/.... toolkits (which are not open-source).
Sorry, I am not java specialist and perhaps for now I don't understand correctly the difference between J2SE/J2ME. But IMO it is a blocker that the files to be installed cannot be rebuilt from open source method. Would you ask Fedora Packaging Committee about this issue?
> Would you ask Fedora Packaging Committee about this issue? How it could be done ?
(In reply to comment #15) > > Would you ask Fedora Packaging Committee about this issue? > How it could be done ? > Please check: http://www.redhat.com/mailman/listinfo/fedora-packaging Post a mail to fedora-packaging , however in advance it is better that you subscribe to the list.
(In reply to comment #16) From post to fedora-packaging: >> So, is it ever possible to package J2ME midlet for Fedora ? >Nicolas Mailhot: >If your stack is not 100% FLOSS you need to incubate at JPackage (or >any other third-party repo) till legal problems are fixed and you can >be accepted @fedora Well, i'm going to remove *jar from anyremote package and distribute non-FLOSS part somethere else.
(In reply to comment #17) > Well, i'm going to remove *jar from anyremote package and distribute > non-FLOSS part somethere else. > Okay, then I will waiting for you to package FLOSS part. If you want to package .jar files, I guess you can ask livna people.
(In reply to comment #18) Updated: Spec URL: http://downloads.sourceforge.net/anyremote/anyremote-fedora.spec?use_mirror=osdn SRPM URL: http://downloads.sourceforge.net/anyremote/anyremote-4.3-4.fc8.src.rpm?use_mirror=osdn
* Source tarball - all source files in srpm should have 0644 permission. * Source tarball -------------------------------------------------------- 1299641 2008-02-18 01:36 anyremote-4.3-2.fc8/anyremote-4.3.tar.gz 933091 2008-03-05 03:57 anyremote-4.3-4.fc8/anyremote-4.3.tar.gz 1299122 2008-02-27 05:18 anyremote-4.3.tar.gz -------------------------------------------------------- - Source tarball changed. * If anyremove 4.3 is already published formally, don't use modified tarball and use the tarball we can actually download from URL written as Source0 * Or can we assume that 4.3 is not formally pushed yet? (it seems you are the upstream developmer) * Spec file name - must be "anyremote.spec", not "anyremote-fedora.spec". * Dependency between subpackages - Dependency between subpackages usually must be EVR (Epoch:Version:Release) specific. i.e. usually "Requires: %{name}-data = %{name}-%{version}". * CFLAGS ---------------------------------------------------------- make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" ---------------------------------------------------------- - Check if this "CFLAGS=..." part really needed. (please check what %configure does by $ rpm --eval %configure again) This is usually not needed. * Docdir - Usually we use %{_defaultdocdir}/%{name}-%{version} (not %{_defaultdocdir}/%{name}) for directory to install documents. Perhaps you want to remove all files under $RPM_BUILD_ROOT%{_defaultdocdir}/%{name} and just use %doc macro. ! * %changelog - By the way, we usually write %changelog at the last.
(In reply to comment #20) > - all source files in srpm should have 0644 permission. Umm... Checked. Which files do You mean ? > * Or can we assume that 4.3 is not formally pushed yet? Actually i'm releasing v4.4 right now. > - must be "anyremote.spec", not "anyremote-fedora.spec". Done. > * Dependency between subpackages > specific. i.e. usually "Requires: %{name}-data = %{name}-%{version}". I separated package to "...-doc" and "...-data" intentionally to have possibility to releasethem separately. So, actually "=" is not only possibly variant. > - Check if this "CFLAGS=..." part really needed. Done. > - Usually we use %{_defaultdocdir}/%{name}-%{version} > (not %{_defaultdocdir}/%{name}) for directory to install documents. Documentation is not changed significantly beetwen releases. Also, as i wrote above it is possible to release "...-doc" subpackage separately, so it seems to me there is no needs to specify it. > - By the way, we usually write %changelog at the last. Done.
Updated Spec URL: http://downloads.sourceforge.net/anyremote/anyremote.spec?use_mirror=osdn SRPM URL: http://downloads.sourceforge.net/anyremote/anyremote-4.4-1.fc8.src.rpm?use_mirror=osdn
Well, where is Source0? (or you have not released 4.4 tarball yet?)
(In reply to comment #23) > Well, where is Source0? (or you have not released 4.4 tarball yet?) Ooops... I'm very sorry for inconvenience. File already uploaded.
Well, one question: Why do you ship pre-compiled objects or binaries like XXXX.o or anyremote in the tarball?
(In reply to comment #25) Oops... seems this is one more error i have to fix :-)
(In reply to comment #25) Fixed.
Okay. - This package itself is okay. - As written on http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored a NEEDSPONSOR submitter are requested to either pre-review other persons' review requests or submit another review request with quality. For your case, you have already submitted some other review requests and I expect they will be accepted with some more fixes. -------------------------------------------------------------------------- This package (anyremote) is APPROVED by me -------------------------------------------------------------------------- Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Get a Fedora Account". At a point a mail should be sent to sponsor members which notifies that you need a sponsor. At the stage, please also write on this bug for confirmation that you requested for sponsorship and your FAS (Fedora Account System) name. Then I will sponsor you. If you want to import this package into Fedora 7/8, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). If you have questions, please ask me.
(In reply to comment #28) > http://fedoraproject.org/wiki/PackageMaintainers/Join Umm... it seems to me something were changed in FAS. At least link https://admin.fedoraproject.org/accounts/userbox.cgi does not works for me. But i registered anyway. FAS name is "anyremote". > At a point a mail should be sent to sponsor members which notifies > that you need a sponsor. Sorry, how i can do that ? > At the stage, please also write on > this bug for confirmation that you requested for sponsorship and > your FAS (Fedora Account System) name. Yes, i requested for sponsorship. My FAS name is "anyremote"
(In reply to comment #29) > (In reply to comment #28) > > http://fedoraproject.org/wiki/PackageMaintainers/Join > Umm... it seems to me something were changed in FAS. Yes, FAS sysadmins are moving FAS to new one... > At least link https://admin.fedoraproject.org/accounts/userbox.cgi does not > works for me. But i registered anyway. FAS name is "anyremote". > > At a point a mail should be sent to sponsor members which notifies > > that you need a sponsor. > Sorry, how i can do that ? This is automated (and I actually received the mail). > > At the stage, please also write on > > this bug for confirmation that you requested for sponsorship and > > your FAS (Fedora Account System) name. > Yes, i requested for sponsorship. My FAS name is "anyremote" Umm.. For now it seems FAS2 is out of operation. Please wait until the problem is solved by sysadmin.
(In reply to comment #28) > - As written on > http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored > a NEEDSPONSOR submitter are requested to either pre-review other > persons' review requests or submit another review request with > quality. > For your case, you have already submitted some other review requests > and I expect they will be accepted with some more fixes. Sorry, i'm not sure what i'm understand this correctly ... Should i do review/approval for 433219 and 433220 by myself ?
(In reply to comment #31) > (In reply to comment #28) > > - As written on > > http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored > > a NEEDSPONSOR submitter are requested to either pre-review other > > persons' review requests or submit another review request with > > quality. > > For your case, you have already submitted some other review requests > > and I expect they will be accepted with some more fixes. > Sorry, i'm not sure what i'm understand this correctly ... > Should i do review/approval for 433219 and 433220 by myself ? No, like this they must be reviewed and accepted by someone else. The difference is that once you are sponsored, they can be reviewed by non-sponsor members (but still you cannot review your own review requests)
>Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> has sponsored you for >membership in the cvsextras Despite of this my status in cvsextras still Unapproved (i'm waiting for several hours already)
I am retrying several times, however I meet with Internal error. If FAS2 still breaks even after I wait for one day more, I will mail to FAS2 sysadmin _again_.
or ping folks on freenode, #fedora-admin
Now it seems okay. Please follow "Join" wiki again.
(In reply to comment #36) Thank You, now my status in cvsextras is Approved. But if i try to set "?" in fedora-cvs i've got: >Flag Modification Denied >You tried to request fedora-cvs. Only an authorized user can make this change. Umm... Did i miss somthing in configuration phase ?
Would you mail to accounts_AT_fedoraproject.org with your FAS name?
(In reply to comment #38) > Would you mail to accounts_AT_fedoraproject.org Thank You for advice!
anyremote: Please try set fedora-cvs now. I've updated your account manually. If it doesn't work, you could also have problems responding to bugs and such so it's good to test this now and make sure it's all working.
Sorry. I meant to leave fedora-cvs unset so you could check that it works for you.
(In reply to comment #41) Thank You it works now
Please write CVS request here written on http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure as well as setting fedora-cvs flag.
New Package CVS Request ======================= Package Name: anyremote Short Description: bluetooth remote control Owners: anyremote Branches: F-8 InitialCC: anyremote Cvsextras Commits: yes
cvs done.
Hi, Now i have the following problem: ./common/cvs-import.sh /_path_to_/anyremote-.....src.rpm ... ERROR: could not check remote file status make: *** [upload] Error 255 ... I changed ~/fedora.cert (how it was written on http://fedoraproject.org/wiki/PackageMaintainers/UsingCvsFaq) several times with no luck. I've wrote a letter to Kevin Fenzi, which created CVS for anyremote, but get no answer. So, i have no idea how to overcome tghis issue.
(In reply to comment #46) > I changed ~/fedora.cert (how it was written on > http://fedoraproject.org/wiki/PackageMaintainers/UsingCvsFaq) > several times with no luck. not ~/fedora.cert but ~/.fedora.cert . Then follow "Join" wiki again. Especially you have to setup client tools as: http://fedoraproject.org/wiki/PackageMaintainers/UsingKoji
(In reply to comment #47) Oops...sorry. It was just a misprinting. I forget a dot. Of cource i've modified ~/.fedora.cert
> (In reply to comment #47) > Oops...sorry. It was just a misprinting. I forget a dot. > Of cource i've modified ~/.fedora.cert What did you mean by "you have modified"? You have to re-download .fedora.cert if you want, and perhaps you have re-run fedora-packager-setup.sh .
(In reply to comment #49) I ve uploaded new ~/.fedora.cert, then rerun ./common/cvs-import.sh /_path_to_/anyremote-.....src.rpm
Are you still seeing some trouble?
Sorry for late responce. I was on vacation. I'm going to re-read updated fedora wiki docs and try again.
I've done "fedora-cvs anyremote" Then as it written at: http://fedoraproject.org/wiki/PackageMaintainers/Anatomy ---------------------- make sources make: *** No rule to make target `sources'. Stop. ---------------------- Umm... Do i need at all to have sources in package directory ?
Oops, sorry. I have to descend to devel/ before run make sources
Please also rebuild this on F-8. After that, visit https://admin.fedoraproject.org/updates/ and request to push your F-8 packages to the repository.
(In reply to comment #55) Umm... Something going wrong here --------------------------------------- cd anyremote/F-8 make tag rpmq: no arguments given for query rpmq: no arguments given for query ---------------------------------------
First upload tarball and spec file as same as devel/ directory. http://fedoraproject.org/wiki/PackageMaintainers/UpdatingPackageHowTo
(In reply to comment #57) > First upload tarball and spec file as same as devel/ directory. I did: ./common/cvs-import.sh -b FC-8 /path/to/anyremote-4.4-1.fc8.src.rpm but nothing changed.
Sorry, typo. I did: ./common/cvs-import.sh -b F-8 /path/to/anyremote-4.4-1.fc8.src.rpm but nothing changed.
Finally, seems it works. I had to do "cvs co" before "make tag"
Okay, then please visit https://admin.fedoraproject.org/updates/ and request F-8 anyremote package to push. For new packages the "Type" is "enhancement". If you want to push your package to fedora updates repository directory (i.e. you want to skip to push your package to "testing" repositofy), change "Request" to "stable". After you request to push on bodhi, please close this bug as "NEXTRELEASE".
s/directory/directly/ ...
OK. But how can "close this bug as "NEXTRELEASE"" ? I've read http://fedoraproject.org/wiki/PackageMaintainers/Join: >Close the Bugzilla ticket when the package has been built successfully. >Remember the Bugzilla ticket for your review? You should close it as >NEXTRELEASE. But did not found status "CLOSED".
Mark "Resolve bug" in this bug report (below) and select "changing resolution to" as "NEXTRELEASE"
Well, but i still did not see anyremote RPM's on Fedora download area. Is it needs to do something else ?
I have to say that recently the cycle of releasing updates package is very slow :( (i.e. it is not because of you) If you want you can change the "Request" type from "testing" to "stable" (I usually request to push directly to stable repository)
At this moment i able to find anyremote packages only in: .../updates/testing/8 So, what do i need to: 1. push anyremote package from updates/testing/8 to updates/8 ? 2. push anyremote to Fedora 9 ?
(In reply to comment #67) > At this moment i able to find anyremote packages only in: > .../updates/testing/8 > > So, what do i need to: > 1. push anyremote package from updates/testing/8 to updates/8 ? For me you seem to have requested to do so, so please just wait. > 2. push anyremote to Fedora 9 ? This is not needed. anyremote will be pushed to F-9.
What does it mean ? ------------------------------------- anyremote has broken dependencies in the development tree: On ppc: anyremote-data-4.4-1.fc8.ppc requires /usr/bin/env On x86_64: anyremote-data-4.4-1.fc8.x86_64 requires /usr/bin/env On i386: anyremote-data-4.4-1.fc8.i386 requires /usr/bin/env On ppc64: anyremote-data-4.4-1.fc8.ppc64 requires /usr/bin/env Please resolve this as soon as possible. --------------------------- rpm -qf /usr/bin/env coreutils*
https://www.redhat.com/archives/fedora-devel-list/2008-May/msg01245.html https://www.redhat.com/archives/fedora-devel-list/2008-May/msg01257.html rawhide yum was broken, ignore it. It is better that you subcribe to fedora-devel-list: http://www.redhat.com/mailman/listinfo/fedora-devel-list
Now i have the following problem: cvs co anyremote Permission denied (publickey) I have a new FAS password, all certs updated, I even checked the cvs procedures for newbies, but I had no luck. What am I doing wrong?