Bug 434704 - Review Request: ocamldsort - Dependency sorter for OCaml source files
Summary: Review Request: ocamldsort - Dependency sorter for OCaml source files
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-02-24 18:09 UTC by Richard W.M. Jones
Modified: 2008-03-03 13:36 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-03-03 13:36:32 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Richard W.M. Jones 2008-02-24 18:09:12 UTC
Spec URL: http://www.annexia.org/tmp/ocaml/ocamldsort.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/ocamldsort-0.14.4-1.fc9.src.rpm
Description: Dependency sorter for OCaml source files

This package is rpmlint-clean.

Comment 1 Parag AN(पराग) 2008-03-01 17:11:52 UTC
build failed 
http://koji.fedoraproject.org/koji/taskinfo?taskID=482326
log said =>
configure: error: Cannot find camlp4.

Comment 2 Richard W.M. Jones 2008-03-01 18:54:58 UTC
Ick, missing camlp4 again.

Spec URL: http://www.annexia.org/tmp/ocaml/ocamldsort.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/ocamldsort-0.14.4-2.fc9.src.rpm

* Sat Mar  1 2008 Richard W.M. Jones <rjones> - 0.14.4-2
- Add missing BR ocaml-camlp4-devel and test in mock.


Comment 3 Parag AN(पराग) 2008-03-02 08:23:11 UTC
Review:
+ package builds in mock (rawhide i386).
koji build =>  http://koji.fedoraproject.org/koji/taskinfo?taskID=483521
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
9651d6afb204c0b22cd69be8a847e1d4  ocamldsort-0.14.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.
APPROVED.


Comment 4 Richard W.M. Jones 2008-03-02 10:54:15 UTC
New Package CVS Request
=======================
Package Name: ocamldsort
Short Description: Dependency sorter for OCaml source files
Owners: rjones
Branches: F-8
InitialCC: rjones
Cvsextras Commits: yes

Comment 5 Kevin Fenzi 2008-03-02 16:47:14 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.