Bug 435058 - Review Request: splat - Analyze point-to-point terrestrial RF communication links
Summary: Review Request: splat - Analyze point-to-point terrestrial RF communication ...
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jeroen van Meeuwen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-02-27 03:09 UTC by Steve Conklin
Modified: 2008-03-03 18:27 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-03-02 22:14:04 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
vanmeeuwen+fedora: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Steve Conklin 2008-02-27 03:09:02 UTC
Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/splat.spec
SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/splat-1.2.1-4.fc9.src.rpm
Description:


SPLAT! is a Surface Path Length And Terrain analysis application written for
Linux and Unix workstations. SPLAT! analyzes point-to-point terrestrial RF 
communication links, and provides information useful to communication system
designers and site engineers.

Comment 1 Jeroen van Meeuwen 2008-02-28 22:16:21 UTC
RPM Lint: OK
Package name: OK
Spec file: OK
License: OK
Actual License: OK
%doc License: OK
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: OK
Compile and Build:
 - F-7: OK
 - F-8: OK
 - rawhide: OK
 - EL-5: OK

Applicable Package Guidelines:
 - -utils subpackage requires base package: OK
 - no duplicate ownership of files and directories between the split packages: OK
 - debuginfo package: small but OK (~12K for a small binary)

Locales: N/A
Shared libs: N/A
Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: OK
%doc affecting runtime: N/A
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: N/A
Library files: N/A
Devel requires base package: N/A
.la libtool archives: OK
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK

Suggestion: move the .desktop and icon file from the -utils subpackage to the
base package.

Comment 2 Steve Conklin 2008-02-29 01:28:15 UTC
Actually, splat has no gui, and needs to be run from the command line.

I removed the desktop file and icon.

New srpm:
http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/splat-1.2.1-6.fc9.src.rpm
New spec:
http://bjensen.fedorapeople.org/pkgs/hams/SPECS/splat.spec


Comment 3 Jeroen van Meeuwen 2008-03-02 15:04:32 UTC
APPROVED

Comment 4 Steve Conklin 2008-03-02 17:06:11 UTC
New Package CVS Request
=======================
Package Name: splat
Short Description: Analyze point-to-point terrestrial RF communication links
Owners: sconklin, bjensen
Branches: F-7 F-8
InitialCC: 
Cvsextras Commits: yes



Comment 5 Kevin Fenzi 2008-03-02 17:23:51 UTC
cvs done.

Comment 6 Fedora Update System 2008-03-02 22:02:54 UTC
splat-1.2.1-6.fc8 has been submitted as an update for Fedora 8

Comment 7 Fedora Update System 2008-03-02 22:03:34 UTC
splat-1.2.1-6.fc7 has been submitted as an update for Fedora 7

Comment 8 Robert 'Bob' Jensen 2008-03-02 22:14:04 UTC
Thank you for the review.

Comment 9 Fedora Update System 2008-03-03 18:23:29 UTC
splat-1.2.1-6.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2008-03-03 18:27:19 UTC
splat-1.2.1-6.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.