Bug 435275
| Summary: | sg_read_long returns bad exit status | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Milos Malik <mmalik> | ||||
| Component: | sg3_utils | Assignee: | Dan Horák <dhorak> | ||||
| Status: | CLOSED ERRATA | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 5.1 | CC: | riek, rvokal, syeghiay | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-09-02 11:23:25 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Just reviewed the source, the return code handling is done incorrectly in sg_read_long. Fix should be easy, so giving Devel ACK and flagging as exception for RHEL-5.2 (not really a blocker as the tool still works on supported machines). Thanks for spotting it Milos. Read ya, Phil Created attachment 296328 [details]
Patch to fix return values for sg_read_long
Bugfix attached, tests here show it works nicely:
[root@hamburg ~]# sg_read_long --16 /dev/sda
sg_read_long: issue read long (16) to device /dev/sda
xfer_len=520 (0x208), lba=0 (0x0), correct=0
SCSI READ LONG (16) command, bad field in cdb
[root@hamburg ~]# echo $?
5
Read ya, Phil
This request was evaluated by Red Hat Product Management for inclusion, but this component is not scheduled to be updated in the current Red Hat Enterprise Linux release. If you would like this request to be reviewed for the next minor release, ask your support representative to set the next rhel-x.y flag to "?". An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2009-1357.html |
From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; cs-CZ; rv:1.8.1.12) Gecko/20080208 Fedora/2.0.0.12-1.fc8 Firefox/2.0.0.12 Description of problem: Even if the command is not supported on the device the utility returns exit code 0. Other utilities in the sg3_utils package return exit code 9 when the command is not supported. sg_read_long: issue read long (16) to device /dev/sda xfer_len=520 (0x208), lba=0 (0x0), correct=0 SCSI READ LONG (16) command not supported Version-Release number of selected component (if applicable): sg3_utils-1.25-1 How reproducible: Always Steps to Reproduce: 1. sg_read_long --16 /dev/sda 2. echo $? Actual Results: exit status is 0 Expected Results: exit status is 9 Additional info: