Bug 436770 - rpm: find-requires parsing problem of objdump -p output
Summary: rpm: find-requires parsing problem of objdump -p output
Alias: None
Product: Fedora
Classification: Fedora
Component: rpm
Version: rawhide
Hardware: arm9
OS: Linux
Target Milestone: ---
Assignee: Panu Matilainen
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: ARMTracker
TreeView+ depends on / blocked
Reported: 2008-03-10 11:58 UTC by Lennert Buytenhek
Modified: 2008-04-18 16:16 UTC (History)
2 users (show)

Fixed In Version: rpm-
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-04-01 08:26:04 UTC

Attachments (Terms of Use)
Make find-requires deal with output following Version References: section. (453 bytes, patch)
2008-03-10 11:58 UTC, Lennert Buytenhek
no flags Details | Diff

Description Lennert Buytenhek 2008-03-10 11:58:23 UTC
autodeps/linux.req expects the 'Version References' section to be
the very last section in objdump -p output and nothing else to follow
it, but at least on Linux/ARM, you can get output a la:

	Version References:
	  required from ld-linux.so.3:
	    0x0d696914 0x00 06 GLIBC_2.4
	  required from libacl.so.1:
	    0x05822450 0x00 05 ACL_1.0
	  required from libgcc_s.so.1:
	    0x0b792655 0x00 04 GCC_3.5
	  required from librt.so.1:
	    0x0d696914 0x00 03 GLIBC_2.4
	  required from libc.so.6:
	    0x0d696914 0x00 02 GLIBC_2.4
	private flags = 4000002: [Version4 EABI] [has entry point]

This last line causes the built package (if the external dep generator
is used) to end up with dependencies such as:

	package: firefox - from f8
	  unresolved deps: 

The attached patch makes find-requires stop parsing dependencies
as soon as a [A-Za-z] character is found in column 1.

Issue found by Rabeeh Khoury <rabeeh@marvell.com>

Comment 1 Lennert Buytenhek 2008-03-10 11:58:23 UTC
Created attachment 297419 [details]
Make find-requires deal with output following Version References: section.

Comment 2 Panu Matilainen 2008-03-13 08:59:05 UTC
Applied upstream (thanks for the patch!), keeping open here for Fedora tracking.

Comment 3 Panu Matilainen 2008-04-01 08:26:04 UTC
In rawhide now...

Comment 4 Bill Nottingham 2008-04-18 16:15:38 UTC
This is very very broken. See 443015.

Note You need to log in before you can comment on or make changes to this bug.