Red Hat Bugzilla – Bug 437052
Review Request: xgridfit - Font hinting tool
Last modified: 2008-03-13 03:09:39 EDT
Spec URL: http://nim.fedorapeople.org/xgridfit.spec
SRPM URL: http://nim.fedorapeople.org/xgridfit-1.5-1.fc9.src.rpm
Xgridfit is a high-level, XML-based language for gridfitting, or "hinting",
fonts. The Xgridfit program compiles an XML source file into tables and
instructions that relate to the gridfitting of glyphs. Xgridfit does not
insert these elements into a font itself, but rather relies on FontForge, the
Open-Source font editor, to do so.
Xgridfit is used in the build stage of some FLOSS fonts, and as such is required to get them packaged Fedora-side, since we build them from source
xgridfit is just a bunch of shell files and xslt filter files, and as such
should be easy to review
I don't think this package contains a lot of documentation to have separate -doc
subpackage. Can you merge -doc to main package?
(In reply to comment #2)
> I don't think this package contains a lot of documentation to have separate -doc
> subpackage. Can you merge -doc to main package?
Are you sure? The documentation is still half the package size, and the debian
maintainer chose to split it too IIRC
Otherwise, un-splitting is dead easy as you know
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=512207
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present in -doc subpackage.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.
Also, you should change Group for -doc to Documentation as given at
(In reply to comment #4)
> Also, you should change Group for -doc to Documentation as given at
Ok, will fix it at CVS import time. Thanks a lot for the lighting-fast review!
New Package CVS Request
Package Name: xgridfit
Short Description: Font hinting tool
Cvsextras Commits: yes
xgridfit-1.5-1.fc8 has been submitted as an update for Fedora 8