Bug 437182 - upstart should ignore rpm temp files
Summary: upstart should ignore rpm temp files
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: upstart
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Casey Dahlin
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-03-12 19:05 UTC by Warren Togami
Modified: 2014-06-18 08:46 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-03-17 03:06:00 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Warren Togami 2008-03-12 19:05:02 UTC
During rpm upgrade of packages that have /etc/event.d/ files like initscripts,
rhgb or upstart itself, it temporarily creates files with names like:
/etc/event.d/serial;47d7dd72 before they are moved into their permanent locations.

Apparently inotify sees the temporary file creation and tells upstart to do
something with it.  Then you get errors on the console like:

init: /etc/event.d/serial;47d7dd72: unable to read: Invalid argument

In addition to ignoring the .rpmsave/.rpmnew files, upstart should also ignore
files with a semicolon in their names.

Comment 1 Casey Dahlin 2008-03-12 19:12:59 UTC
That's kind of a broad category, subject to user gotchas. Might be better to
tell upstart not to watch inotify for a bit while the packages are upgraded.

Why do these files have to be generated in this folder?

Comment 2 Bill Nottingham 2008-03-12 19:21:01 UTC
If they're generated anywhere else by rpm, they can't be atomically renamed in
place.

Comment 3 Warren Togami 2008-03-12 19:22:45 UTC
Realistically how many times are files with semicolons in their names used?

> Why do these files have to be generated in this folder?

How do you propose we do this in a reliable way?

Comment 4 Bill Nottingham 2008-03-12 19:26:58 UTC
Match on ';<8 hex digits>' at the end of the file name, I suppose. It would be
used for any file being laid down by rpm.

Comment 5 Casey Dahlin 2008-03-12 19:44:57 UTC
Ok. I'll look at a patch for this.

Comment 6 Casey Dahlin 2008-03-17 03:06:00 UTC
Fixed in upstart-0.3.9-13



Note You need to log in before you can comment on or make changes to this bug.