Bug 437249 - redhat-rpm-config: find-requires parsing problem of objdump -p output
Summary: redhat-rpm-config: find-requires parsing problem of objdump -p output
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: redhat-rpm-config
Version: rawhide
Hardware: arm9
OS: Linux
low
low
Target Milestone: ---
Assignee: Jon Masters
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: ARMTracker
TreeView+ depends on / blocked
 
Reported: 2008-03-13 08:27 UTC by Lennert Buytenhek
Modified: 2008-05-06 23:04 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2008-05-06 23:01:42 UTC


Attachments (Terms of Use)
Make find-requires deal with output following Version References: section. (443 bytes, patch)
2008-03-13 08:27 UTC, Lennert Buytenhek
no flags Details | Diff

Description Lennert Buytenhek 2008-03-13 08:27:17 UTC
find-requires expects the 'Version References' section to be the
very last section in objdump -p output and nothing else to follow
it, but at least on Linux/ARM, you can get output a la:

	Version References:
	  required from ld-linux.so.3:
	    0x0d696914 0x00 06 GLIBC_2.4
	  required from libacl.so.1:
	    0x05822450 0x00 05 ACL_1.0
	  required from libgcc_s.so.1:
	    0x0b792655 0x00 04 GCC_3.5
	  required from librt.so.1:
	    0x0d696914 0x00 03 GLIBC_2.4
	  required from libc.so.6:
	    0x0d696914 0x00 02 GLIBC_2.4
	private flags = 4000002: [Version4 EABI] [has entry point]

This last line causes the built package (if the external dep generator
is used) to end up with dependencies such as:

	package: firefox - 2.0.0.8-2.fc8.armv5tel from f8
	  unresolved deps: 
	     ld-linux.so.3(4000002:)
	     libgcc_s.so.1(4000002:)
	     libstdc++.so.6(4000002:)
	     libc.so.6(4000002:)
	     libpng12.so.0(4000002:)
	     libsmime3.so(4000002:)

The attached patch makes find-requires stop parsing dependencies
as soon as a [A-Za-z] character is found in column 1, and was recently
applied to upstream rpm's copy of find-requires:

    https://lists.dulug.duke.edu/pipermail/rpm-maint/2008-March/000846.html
    https://lists.dulug.duke.edu/pipermail/rpm-maint/2008-March/000858.html

However, redhat-rpm-config carries a (modified) copy of this file,
which also needs patching -- the attached patch does that.

Comment 1 Lennert Buytenhek 2008-03-13 08:27:17 UTC
Created attachment 297903 [details]
Make find-requires deal with output following Version References: section.

Comment 2 Jon Masters 2008-05-06 23:04:52 UTC
Can you test the next rawhide build? Otherwise, let me know and I'll send you a
package to test :)


Note You need to log in before you can comment on or make changes to this bug.