Red Hat Bugzilla – Bug 437391
RT2500 from kernel-126.96.36.199-137.fc8 - no power LED
Last modified: 2009-01-22 16:23:51 EST
Up to kernel-188.8.131.52-137.fc8 the link LED did not work, but the power LED
worked. From kernel-184.108.40.206-137.fc8 onwards the link LED started working, but
the power LED stopped working.
Just got hold of a brand new RT2500 pmcia card and I am still experiencing the
same problem (on the same laptop).
Just an update.
Installed kernels 220.127.116.11-74.fc8 and 18.104.22.168-82.fc8.
Problem still not solved.
Just found an obvious typo in the led handling in rt2x00.
This fix should fix both the activity as well as the radio led.
Patch will be pushed to mainstream in 1 or 2 days.
I have pushed the patch a day earlier. :)
John, the patch is part of the 2.1.5 release series,
more specifically patch: "[PATCH 5/9] rt2x00: Fix quality/activity led
Hopefully that patch resolves this issue. :)
Is this problem still happening with the latest f8 kernels?
I installed F9 two days ago, therefore I cannot test F8 anymore.
On F9 kernel 22.214.171.124-18.fc9.i686 the problem is still happening.
Can you recreate this issue with the kernels here?
Installed kernel 126.96.36.199-26.fc9.i686 but the system freezes as soon as the
network card is activated. It looks as if the power LED does not work anyway,
because only the link LED goes on.
Installed kernel kernel-188.8.131.52-39.fc9
System starts fine, network detected, but it does no manage to connect (it
connects fine with kernel 184.108.40.206-18.fc9.i686).
Power LED still not working.
Does the problem persist with 2.6.27-based kernels?
I still have the PCMCIA card, but I do not have the laptop I used to test it with any more. I will give you an update as soon as possible (I should have another laptop to test it with in a week or so).
Just tested on kernel-220.127.116.11-117.fc10 and the problem persists.
This is just the power LED not working, correct?
Yes, it is just power LED that is not working.
I have just tested the card on another laptop running F10 and it does not work on that either.
Ivo, is this patch likely to help here?
Author: Andrew Price <email@example.com>
Date: Sat Jan 10 19:38:05 2009 +0000
rt2400,rt2500: init led_qual for LED_MODE_DEFAULT
Add a check for LED_MODE_DEFAULT so that we use the link LED for rt2400
and rt2500 devices.
Signed-off-by: Andrew Price <firstname.lastname@example.org>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <email@example.com>
Don't think so, the power LED was registered by default and hence should be toggled by default. The above patch would fix the link LED, rather then the power LED, while the link LED is working for Ivan.
Ivan, could you try mounting debugfs and using http://kernel.org/pub/linux/kernel/people/ivd/tools/rt2x00_regdump.sh to make a dump of the registers?
Perhaps that might show something interesting about the LED type.
Created attachment 329145 [details]
Dump of the register
The LED type is "ASUS" (not very descriptive about what to expect from the led :S)
The original drivers were always treating that type very specially, and I need to check if I ported that correctly. I'll get back on this in a few days.
I have send a patch upstream which should fix this issue, the original code is a bit vague since it suggests that led type "ASUS" means that there is only 1 LED, namely the activity LED.
The patch will register both power and activity LEDs, so hopefully that will work as expected.
I've added this and a related patch to the kernel being built here:
Please give that a try when the build complete and post the results here...thanks!
Kernels from comment 20 have been built successfully. Please give them a try!
Well done everyone... You can close this bug...
Both LEDs are on now (connection one flashing, of course)...
Now we just need to make it connect... see:
Fedora 10 - https://bugzilla.redhat.com/show_bug.cgi?id=473432
Fedora 9 - https://bugzilla.redhat.com/show_bug.cgi?id=457441