Spec URL: http://davej.fedorapeople.org/msr-tools.spec SRPM URL: http://davej.fedorapeople.org/msr-tools-1.1.2-1.src.rpm Description: Two tools to read/write processor model specific registers
meh; this seem to suffer from the very same problems as bug #437397 So I'll take also this one for review.
spec updated with comments from 437397 srpm url changed to http://davej.fedorapeople.org/msr-tools-1.1.2-1.fc9.src.rpm thanks.
1.) Package currently won't build: install rdmsr %{buildroot}%{_sbindir}/rdmsr install wrmsr %{buildroot}%{_sbindir}/wrmsr Did you mean "install -D there"? 2.) Some cosmetical things: msr-tools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 36) msr-tools.src: W: summary-ended-with-dot Collection of tools for reading/writing CPU model specific registers. msr-tools.x86_64: W: incoherent-version-in-changelog 1.1.2 1.1.2-1.fc8 the last one is the same as bug #437397 comment #3 -- the changelog header should end with " - 1.1.2-1" (no dist tag there, contrary to what rpmlint output above suggests) I see no more issues with the package. I'll approve it once these are addressed.
Oh, pardon me -- one more minor thing: "-n %{name}-%{version}" as %setup macro argument is not necessary.
Thanks, Updated.
msr-tools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 36) Just remove the dot, so that rpmlint is happy, when importing :) Does not warrant a review blocker though APPROVED
Please use a cvs template here so we know what branches you want, etc... see: http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure
New Package CVS Request ======================= Package Name: msr-tools Short Description: Collection of tools for reading/writing CPU model specific registers. Owners: davej Branches: InitialCC: Cvsextras Commits: yes
cvs done.
Package Change Request ====================== Package Name: msr-tools New Branches: el6 epel7 Owners: davej gbailey
Package Change Request ====================== Package Name: msr-tools New Branches: el5 Owners: davej gbailey
Git done (by process-git-requests).
Repeating this request as it apparently was skipped when I added an additional request for the el5 branch... Package Change Request ====================== Package Name: msr-tools New Branches: el6 epel7 Owners: davej gbailey