Spec URL: http://www.auroralinux.org/people/spot/review/new/python-ply.spec SRPM URL: http://www.auroralinux.org/people/spot/review/new/python-ply-2.3-1.fc9.src.rpm Description: PLY is a straightforward lex/yacc implementation. Here is a list of its essential features: * It is implemented entirely in Python. * It uses LR-parsing which is reasonably efficient and well suited for larger grammars. * PLY provides most of the standard lex/yacc features including support for empty productions, precedence rules, error recovery, and support for ambiguous grammars. * PLY is straightforward to use and provides very extensive error checking. * PLY doesn't try to do anything more or less than provide the basic lex/yacc functionality. In other words, it's not a large parsing framework or a component of some larger system.
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=519008 + rpmlint is silent for SRPM and for RPM. + source files match upstream. e406e5eef98661d395d901f8cc3d1219 ply-2.3.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. Suggestions: You can add examples directory as %doc. APPROVED.
ping?
Package Name: python-ply Short Description: Python Lex-Yacc Owners: spot Branches: F-7 F-8 EL-4 EL-5 InitialCC: Cvsextras Commits: yes
cvs done.
Committed and built, thanks for the review.