Bug 437773

 - This appears to block adding an iSCSI volume while in text-mode, since the
the text-mode prompt states to boot with "linux asknetwork" to enable networking.

Created attachment 298260 [details]
anaconda-files.tgz

> tar -ztvf Desktop/anaconda-files.tgz 
-rw-r--r-- root/0	 16221 2008-03-17 08:03 tmp/anaconda.log
-rw-r--r-- root/0	 12915 2008-03-17 08:02 tmp/syslog
-rw-r--r-- root/0	   121 2008-03-17 08:04 tmp/cmdline
-rwxr-xr-x root/0	  1200 2008-03-17 08:01 tmp/vncserver.log
-rw-r--r-- root/0	    98 2008-03-17 07:58 tmp/scsidisks
-rw-r--r-- root/0	    52 2008-03-17 07:58 tmp/modprobe.conf

Adding Regression keyword since this is a change in behavior from 5.1 and 5.0
and on further inspection appears to prevent the user from manually adding an
iSCSI device altogether.

To recreate:

1) Boot installer by any means using a network installation source (method=http://)
2) at disk prompt, select "Advanced Storage Configuration"
3) a networking dialog appears (it shouldn't), click OK 

Actual results:
 - no network dialog should appear if networking is already configured

Expected result:
 - no network dialog (it's already setup)

The problem here is with an incorrect nl_object_put() call in nl_ip2str() in nl.c.  What I do is first look up 
the index number of the interface you specified.  For example, on my test system, eth1 is interface 
index 4 in netlink-world.  Once I have that, I gather all address objects and iterate over them matching 
the interface index number.  When I find an address type of AF_INET or AF_INET6, I store it for the 
caller.

The loop was broken because I had nl_object_put() at the end, so when the next loop iteration went to 
run, nl_cache_get_next() returned nothing because I had gotten rid of my current object.  You have to 
pass the current object to nl_cache_get_next() to get the next one.  Here's the fix:

diff --git a/isys/nl.c b/isys/nl.c
index 13b1beb..e7bd60c 100644
--- a/isys/nl.c
+++ b/isys/nl.c
@@ -160,8 +160,6 @@ char *nl_ip2str(char *ifname) {
                 }
             }
         }
-
-        nl_object_put(obj);
     } while ((obj = nl_cache_get_next(obj)) != NULL);
 
 ip2str_error:

This problem is reproduceable on all platforms.  Giving it a devel-ack.

Patch committed to anaconda git repository, will be included in the anaconda-11.1.2.111-1 build.

*** Bug 439846 has been marked as a duplicate of this bug. ***

verified fix in RHEL5.2-Server-20080402.0 for s390x ...

Update to issue 171202 by bugzilla
> Action: These changes made by borgan.
> Bugzilla comment added:
>  verified fix in RHEL5.2-Server-20080402.0 for s390x ...
> 
> 
> Bugzilla status changed from 'ON_QA' to 'VERIFIED'
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=437773 

The "networking dialog" doesn't appear anymore, but after installing,
it
fails
to boot from the iscsi-disk, we use RHEL5.2 snapshot4:

.....
-----------------------------------------------------
Linux version 2.6.18-88.el5 (brewbuilder.redhat.com)
(gcc
version 4.1.2 20071124 (Red Hat 4.1.2-41)) #1 SMP Tue Apr 1 19:06:25 EDT
2008
[boot]0012 Setup Arch
EEH: PCI Enhanced I/O Error Handling Enabled
PPC64 nvram contains 15360 bytes
[boot]0015 Setup Done
Built 1 zonelists.  Total pages: 122880
Kernel command line: root=/dev/VolGroup01/LogVol00 ro console=hvc0 rhgb
quiet
scan-log-dump not implemented on this system
Red Hat nash version 5.1.19.6 starting
iscsistart: transport class version 2.0-724. iscsid version 2.0-868
iscsistart: version 2.0-868
iscsistart: cannot make a connection to 10.100.0.140:3260 (101)
iscsistart: initiator reported error (4 - encountered connection failure)
  Reading all physical volumes.  This may take a while...
  Found volume group "VolGroup00" using metadata type lvm2
  Volume group "VolGroup01" not found
mount: could not find filesystem '/dev/root'
setuproot: moving /dev failed: No such file or directory
setuproot: error mounting /proc: No such file or directory
setuproot: error mounting /sys: No such file or directory
switchroot: mount failed: No such file or directory
Kernel panic - not syncing: Attempted to kill init!
 ehea: Error in ehea_treat_poll_error: CQE Error for QP 16 


This event sent from IssueTracker by jkachuck 
 issue 171202

changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |REOPENED
         Resolution|FIX_BY_DISTRO               |




------- Additional Comments From hanpt.com  2008-04-10 21:53 EDT
-------
System hangs after installing with Snapshot4. Will reopen this bug. Please
see
comment #31 for more messages. 


This event sent from IssueTracker by jkachuck 
 issue 171202

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2008-0397.html