SRPM URL: http://fedora.biggerontheinside.net/review/perl-Test-WWW-Mechanize-Catalyst-0.41-1.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Test-WWW-Mechanize-Catalyst.spec Description: Catalyst is an elegant MVC Web Application Framework. Test::WWW::Mechanize is a subclass of WWW::Mechanize that incorporates features for web application testing. The Test::WWW::Mechanize::Catalyst module meshes the two to allow easy testing of Catalyst applications without starting up a web server.
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=520520
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=520520 + rpmlint is silent for SRPM and for RPM. + source files match upstream url efffcede181df9658c99472e51cade3f Test-WWW-Mechanize-Catalyst-0.41.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=6, Tests=79, 2 wallclock secs ( 2.06 cusr + 0.29 csys = 2.35 CPU) + Package perl-Test-WWW-Mechanize-Catalyst-0.41-1.fc9 => Provides: perl(Test::WWW::Mechanize::Catalyst) = 0.41 perl(Test::WWW::Mechanize::Catalyst::Aux) Requires: perl(Catalyst) perl(Encode) perl(HTML::Entities) perl(Test::WWW::Mechanize) perl(base) perl(strict) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Test-WWW-Mechanize-Catalyst Short Description: Test::WWW::Mechanize for Catalyst Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig
cvs done.
Thanks for the review! :)
Package Change Request ====================== Package Name: perl-Test-WWW-Mechanize-Catalyst New Branches: el6 Owners: bochecha Chris doesn't maintain his packages in EPEL, but doesn't have a problem with others doing so.
Git done (by process-git-requests).