Bug 437923 - Review Request: perl-Test-WWW-Mechanize-Catalyst - Test::WWW::Mechanize for Catalyst
Summary: Review Request: perl-Test-WWW-Mechanize-Catalyst - Test::WWW::Mechanize for C...
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/Test-WWW-...
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-03-18 06:29 UTC by Chris Weyl
Modified: 2011-07-12 04:55 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-03-18 20:07:40 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2008-03-18 06:29:24 UTC
SRPM URL: http://fedora.biggerontheinside.net/review/perl-Test-WWW-Mechanize-Catalyst-0.41-1.fc8.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-Test-WWW-Mechanize-Catalyst.spec

Description:
Catalyst is an elegant MVC Web Application Framework. Test::WWW::Mechanize
is a subclass of WWW::Mechanize that incorporates features for web
application testing. The Test::WWW::Mechanize::Catalyst module meshes the
two to allow easy testing of Catalyst applications without starting up a
web server.

Comment 1 Chris Weyl 2008-03-18 06:29:46 UTC
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=520520


Comment 2 Parag AN(पराग) 2008-03-18 08:32:20 UTC
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=520520
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
efffcede181df9658c99472e51cade3f  Test-WWW-Mechanize-Catalyst-0.41.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=6, Tests=79,  2 wallclock secs ( 2.06 cusr +  0.29 csys =  2.35 CPU)
+ Package perl-Test-WWW-Mechanize-Catalyst-0.41-1.fc9 =>
  Provides: perl(Test::WWW::Mechanize::Catalyst) = 0.41
perl(Test::WWW::Mechanize::Catalyst::Aux)
  Requires: perl(Catalyst) perl(Encode) perl(HTML::Entities)
perl(Test::WWW::Mechanize) perl(base) perl(strict) perl(warnings)

APPROVED.

Comment 3 Chris Weyl 2008-03-18 14:53:36 UTC
New Package CVS Request
=======================
Package Name: perl-Test-WWW-Mechanize-Catalyst
Short Description: Test::WWW::Mechanize for Catalyst
Owners: cweyl
Branches: F-7, F-8, devel
InitialCC: perl-sig

Comment 4 Kevin Fenzi 2008-03-18 17:36:50 UTC
cvs done.

Comment 5 Chris Weyl 2008-03-18 20:07:40 UTC
Thanks for the review! :)

Comment 6 Mathieu Bridon 2011-07-12 04:21:34 UTC
Package Change Request
======================
Package Name: perl-Test-WWW-Mechanize-Catalyst
New Branches: el6
Owners: bochecha

Chris doesn't maintain his packages in EPEL, but doesn't have a problem with others doing so.

Comment 7 Gwyn Ciesla 2011-07-12 04:55:09 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.