Bug 437963 - configuration not saved atomically
Summary: configuration not saved atomically
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: gqview
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Michael Schwendt
QA Contact: Fedora Extras Quality Assurance
URL: https://sourceforge.net/tracker/?func...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-03-18 13:25 UTC by Roberto Jimeno
Modified: 2008-03-18 16:02 UTC (History)
0 users

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-03-18 16:02:58 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Roberto Jimeno 2008-03-18 13:25:15 UTC
Description of problem:
configuration is not saved atomically. So on errors
like out of space a 0 sized file overwrites a good
configuration.

Instead gqview should write configuration to a temp
file and when everything went OK replace the new
configuration file with the old one.

Version-Release number of selected component (if applicable): 2.0.4


How reproducible:
Steps to Reproduce:
1. change a setting in gqview
2. fill disk space
3. quit gqview
4. your gqview config is gone
  
Actual results:
config is gone on full disk

Expected results:
config should be kept on full disk

Additional info:
Severity is high because config is lost

Comment 1 Michael Schwendt 2008-03-18 16:02:58 UTC
Thank you for reporting this, but it's in the upstream tracker
already.

> Date Submitted: 2005-10-03 01:56

I'm not going to fork GQview for a very rare out-of-disk-space
scenario like this when there hasn't been any upstream activity
for more than a year. The implementation is broken by design in
that hardly any fwrite/fprintf return value elsewhere is checked
either. See "grep fprintf * -R|less" for example.



Note You need to log in before you can comment on or make changes to this bug.