SRPM URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-View-TT-0.26-1.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-View-TT.spec Description: This is the Catalyst view base class for the Template Toolkit.
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=521583
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=521583 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 653f58f818a1b0b3d0ad28b62c13241b Catalyst-View-TT-0.26.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=8, Tests=38, 1 wallclock secs ( 1.50 cusr + 0.21 csys = 1.71 CPU) + Package perl-Catalyst-View-TT-0.26-1.fc9 => Provides: perl(Catalyst::Helper::View::TT) perl(Catalyst::Helper::View::TTSite) perl(Catalyst::View::TT) = 0.26 Requires: perl(Catalyst) perl(Data::Dump) perl(File::Spec) perl(NEXT) perl(Path::Class) perl(Template) perl(Template::Timer) perl(base) perl(strict) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Catalyst-View-TT Short Description: Template Toolkit View Class Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig
cvs done.
Thanks for the review!
Package Change Request ====================== Package Name: perl-Catalyst-View-TT New Branches: el6 Owners: iarnell tremble
Git done (by process-git-requests).