SRPM URL: http://fedora.biggerontheinside.net/review/perl-Object-Signature-1.05-1.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Object-Signature.spec Description: Object::Signature is an abstract base class that you can inherit from in order to allow your objects to generate unique cryptographic signatures.
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=521950
Is this needed here? BuildRequires: perl >= 0:5.005
Not strictly speaking, no, tho it is listed as a requirement in META.yml. SRPM URL: http://fedora.biggerontheinside.net/review/perl-Object-Signature-1.05-2.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Object-Signature.spec
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=527776 + rpmlint is silent for SRPM and for RPM. + source files match upstream url b154a57c64ac06bd47b364c924bf3738 Object-Signature-1.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave t/01_compile....ok t/02_main.......ok t/99_author.....skipped all skipped: Author tests not required for installation All tests successful, 1 test skipped. + Package perl-Object-Signature-1.05-2.fc9 => Provides: perl(Object::Signature) = 1.05 Requires: perl >= 0:5.005 perl(strict) perl(vars) APPROVED.
New Package CVS Request ======================= Package Name: perl-Object-Signature Short Description: Cryptographically strong objects Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig
cvs done.
Importeed and built. Thanks for the review! :)
Package Change Request ====================== Package Name: perl-Object-Signature New Branches: el6 Owners: iarnell Chris doesn't maintain his packages in EPEL, but doesn't have a problem with others doing so.
Git done (by process-git-requests).