Red Hat Bugzilla – Bug 438561
Review Request: isight-firmware-tools - Firmware extraction tools for Apple Built-in iSight camera
Last modified: 2008-03-26 01:06:13 EDT
Spec URL: http://rishi.fedorapeople.org/isight-firmware-tools.spec SRPM URL: http://rishi.fedorapeople.org/isight-firmware-tools-1.0.2-1.fc8.src.rpm Description: iSight Firmware Tools provide tools to manipulate firmware for Built-in iSight cameras found on Apple machines since iMac G5 (November 2005).
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=525803
Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=525803 + rpmlint is silent for SRPM and for RPM. + source files match upstream. b8d1e80cf8d47f9aa4f683b995cd359c isight-firmware-tools-1.0.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + install-info scriptlets are used. + Not a GUI app. APPROVED.
There was a broken path in the udev rules file. I have fixed it now. Spec:http://rishi.fedorapeople.org/isight-firmware-tools.spec SRPM:http://rishi.fedorapeople.org/isight-firmware-tools-1.0.2-2.fc8.src.rpm Koji:http://koji.fedoraproject.org/koji/taskinfo?taskID=528804
New Package CVS Request ======================= Package Name: isight-firmware-tools Short Description: Firmware extraction tools for Apple Built-in iSight camera Owners: rishi Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Tagged and built for F-8 and Rawhide. F-7 does not have a 2.6.24.x kernel so the linux-uvc driver might be missing. Will provide for F-7 if there is a demand for it.