Bug 439431
| Summary: | include patch to add FATTR4_RDATTR_ERROR to readdir calls | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 4 | Reporter: | Jeff Layton <jlayton> | ||||
| Component: | kernel | Assignee: | Jeff Layton <jlayton> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Martin Jenner <mjenner> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 4.7 | CC: | riek, rlerch, staubach, steved | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: |
previously, when a NFSv4 (Network File System Version 4) client encountered issues while processing a directory using readdir(), an error for the entire readdir() call was returned. With this update, the "fattr4_rdattr_error" flag is now set when readdir() is called, instructing the server to continue on and only report an error on the specific directory entry that was causing the issue.
|
Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-05-18 19:31:25 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 227610 | ||||||
| Bug Blocks: | 458752, 461304 | ||||||
| Attachments: |
|
||||||
|
Description
Jeff Layton
2008-03-28 17:44:44 UTC
When I proposed the patch for bug 227610, Peter mentioned that we should consider the patch to add the rdattr_error attribute to NFS4 READDIR calls. I wasn't able to get it done and proposed in time for 4.7, so I've opened this to track whether we want to include it for 4.8. In general, it makes sense to me that we should request more granular errors in readdir calls. We don't in general want to have the entire READDIR error out just because one entry was bad. The only issue is that I don't have a clear situation/reproducer where this is needed. We'll probably need to concoct one for the QA group, so that may be the challenge here. Created attachment 299505 [details]
patch -- add support for rdattr_error in NFSv4 readdir
Patch that adds support for this option. I've verified that it works by
inspection, but if we want to include it, we probably need to come up with a
clear situation that this fixes...
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. Updating PM score. Committed in 78.28.EL . RPMS are available at http://people.redhat.com/vgoyal/rhel4/ Release note added. If any revisions are required, please set the "requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: When a NFSv4 server is issued a READDIR call and has a problem getting info on one or more entries in a directory, it can either return an error for the entire readdir call or it can return what info it did find and flag the problem entries with an error. This behavior is governed by a flag in the READDIR call, which indicates how errors should be reported. This patch makes the RHEL4 NFSv4 client request and handle more granular error reporting. Release note updated. If any revisions are required, please set the "requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1,3 +1 @@ -When a NFSv4 server is issued a READDIR call and has a problem getting info on one or more entries in a directory, it can either return an error for the entire readdir call or it can return what info it did find and flag the problem entries with an error. +previously, when a NFSv4 (Network File System Version 4) client encountered issues while processing a directory using readdir(), an error for the entire readdir() call was returned. With this update, the "fattr4_rdattr_error" flag is now set when readdir() is called, instructing the server to continue on and only report an error on the specfic directory that was causing the issue.- -This behavior is governed by a flag in the READDIR call, which indicates how errors should be reported. This patch makes the RHEL4 NFSv4 client request and handle more granular error reporting. Release note updated. If any revisions are required, please set the "requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1 +1 @@ -previously, when a NFSv4 (Network File System Version 4) client encountered issues while processing a directory using readdir(), an error for the entire readdir() call was returned. With this update, the "fattr4_rdattr_error" flag is now set when readdir() is called, instructing the server to continue on and only report an error on the specfic directory that was causing the issue.+previously, when a NFSv4 (Network File System Version 4) client encountered issues while processing a directory using readdir(), an error for the entire readdir() call was returned. With this update, the "fattr4_rdattr_error" flag is now set when readdir() is called, instructing the server to continue on and only report an error on the specfic directory entry that was causing the issue. Release note updated. If any revisions are required, please set the "requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. Diffed Contents: @@ -1 +1 @@ -previously, when a NFSv4 (Network File System Version 4) client encountered issues while processing a directory using readdir(), an error for the entire readdir() call was returned. With this update, the "fattr4_rdattr_error" flag is now set when readdir() is called, instructing the server to continue on and only report an error on the specfic directory entry that was causing the issue.+previously, when a NFSv4 (Network File System Version 4) client encountered issues while processing a directory using readdir(), an error for the entire readdir() call was returned. With this update, the "fattr4_rdattr_error" flag is now set when readdir() is called, instructing the server to continue on and only report an error on the specific directory entry that was causing the issue. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2009-1024.html |