Bug 439651 - use uint64_t instead of u_quad_t
Summary: use uint64_t instead of u_quad_t
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: libvirt
Version: 9
Hardware: All
OS: Other
low
low
Target Milestone: ---
Assignee: Daniel Veillard
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-03-30 01:07 UTC by Mike Gerdts
Modified: 2009-03-10 12:34 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-03-10 12:34:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Convert u_quad_t to uint64_t (1.81 KB, patch)
2008-03-30 01:07 UTC, Mike Gerdts
no flags Details | Diff
Convert u_quad_t to uint64_t (remote_protocol.{c,h}) (5.72 KB, patch)
2008-03-30 18:44 UTC, Mike Gerdts
no flags Details | Diff

Description Mike Gerdts 2008-03-30 01:07:16 UTC
Description of problem:

Solaris does not define u_quad_t, which is used in qemud/remote_protocol.h.

According to http://cygwin.com/ml/cygwin/2005-03/msg00323.html it is an -ism
rather than a standard.  Perhaps uint64_t is a better 
Version-Release number of selected component (if applicable):

CVS as of March 29, 2008

How reproducible:

Every time

Steps to Reproduce:
1. Be sure you are on Solaris.
2. Check out code from cvs
3. Try to build the code
  
Actual results:

In file included from remote_internal.c:73:
../qemud/remote_protocol.h:97: error: syntax error before "u_quad_t"
../qemud/remote_protocol.h:97: warning: no semicolon at end of struct or union
../qemud/remote_protocol.h:99: error: syntax error before '}' token
. . .


Expected results:


Additional info:

Comment 1 Mike Gerdts 2008-03-30 01:07:16 UTC
Created attachment 299601 [details]
Convert u_quad_t to uint64_t

Comment 2 Mike Gerdts 2008-03-30 18:43:04 UTC
Comment on attachment 299601 [details]
Convert u_quad_t to uint64_t

missed required changes in remote_protocol.c

Comment 3 Mike Gerdts 2008-03-30 18:44:19 UTC
Created attachment 299633 [details]
Convert u_quad_t to uint64_t (remote_protocol.{c,h})

Comment 4 Richard W.M. Jones 2008-03-31 10:07:43 UTC
These two files are autogenerated from remote_protocol.x.

What happens if you run rpcgen on remote_protocol.x?

Comment 5 Richard W.M. Jones 2008-03-31 10:08:37 UTC
... or rather, delete those two files and run 'make -C qemud'

Comment 6 Bug Zapper 2008-05-14 08:25:27 UTC
Changing version to '9' as part of upcoming Fedora 9 GA.
More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 7 Daniel Berrangé 2009-03-10 12:34:25 UTC
This problem was addressed in the 0.6.0 release, we now use uint64_t.


Note You need to log in before you can comment on or make changes to this bug.