Bug 440251 - Minor defect in nanny
Minor defect in nanny
Product: Red Hat Cluster Suite
Classification: Red Hat
Component: piranha (Show other bugs)
All Linux
low Severity low
: ---
: ---
Assigned To: Marek Grac
Cluster QE
: 450166 (view as bug list)
Depends On: 439814
  Show dependency treegraph
Reported: 2008-04-02 10:30 EDT by Marek Grac
Modified: 2009-04-16 16:36 EDT (History)
2 users (show)

See Also:
Fixed In Version: RHBA-2008-0794
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-07-25 15:09:03 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Marek Grac 2008-04-02 10:30:42 EDT
+++ This bug was initially created as a clone of Bug #439814 +++

Description of problem:

In reviewing the nanny code I discovered what appears to be a minor coding 

char *
getExecOutput (int flags, char **argv, int timeout)
        pipe (p);

        if (!(child = fork ())) {
                int stdin, stderr;

                execvp (argv[0], argv);
                exit (1);

        close (p[1]);

        alarm (timeout);

        needsKilling = child;
        sigprocmask (SIG_UNBLOCK, &sigs, &oldSigs);

        rc = waitpid (child, &status, 0);          <--------- rc
        sigprocmask (SIG_SETMASK, &oldSigs, NULL);
        needsKilling = 0;

        if (rc < 0) {
                if (rc == EINTR)                  <------------- bug!! Should be
                        piranha_log (flags, (char *)
                                     "unexpected return \"%s\" running the
                        piranha_log (flags,
                                     (char *) "timeout running the following:");

The above code makes a check of rc as though it is an errno, this is incorrect,
the syscall
rc value will be -1 and errno would be set to EINTR, as per the waitpid man page:


       wait(): on success, returns the process ID of the terminated child; on
error, -1 is returned.

       waitpid(): on success, returns the process ID of the child whose state
has changed; on error, -1 is returned;  if  WNO-
       HANG was specified and no child(ren) specified by pid has yet changed
state, then 0 is returned.

       waitid():  returns 0 on success or if WNOHANG was specified and no
child(ren) specified by id has yet changed state; on
       error, -1 is returned.

       Each of these calls sets errno to an appropriate value in the case of an
Comment 1 RHEL Product and Program Management 2008-04-02 12:48:35 EDT
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
Comment 2 Marek Grac 2008-04-04 05:58:27 EDT
Fixed in CVS
Comment 4 Marek Grac 2008-06-05 13:00:53 EDT
*** Bug 450166 has been marked as a duplicate of this bug. ***
Comment 6 errata-xmlrpc 2008-07-25 15:09:03 EDT
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.