Spec URL: http://huzaifas.fedorapeople.org/spec/python-lzo.spec SRPM URL: http://huzaifas.fedorapeople.org/srpms/python-lzo-1.08-1.fc8.src.rpm Koi Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=545850 Description: Python bindings for lzo compression libraries.
1)Remove 2 times written README from following line %doc COPYING NEWS README README 2)Change %files section line from %{python_sitelib}/lzo.so to %{python_sitelib}/* 3)You need to add BuildRequires: python-setuptools-devel 4)License is GPLv2+
%install should have %{__python} setup.py install --skip-build --root $RPM_BUILD_ROOT as per given in http://fedoraproject.org/wiki/Packaging/Python#head-b0fc6f14e88db17db3633889f31880adcefb9cb8
I rechecked egginfo guidelines and found that you don't need BuildRequires: python-setuptools-devel for F9 and above as its automatically generating egginfo You need to provide egginfo for <F9 builds by following http://fedoraproject.org/wiki/Packaging/Python/Eggs#head-4ac98208bf2f5a13b9cd997c91e2e424f67a7e35
provide updated SRPM for further review.
for F8 build to generate egginfo you can change your spec to add build and install sections as %build %if 0%{?fedora} > 8 CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build %else CFLAGS="$RPM_OPT_FLAGS" %{__python} -c 'import setuptools; execfile("setup.py")' build %endif %install rm -rf $RPM_BUILD_ROOT %if 0%{?fedora} > 8 %{__python} setup.py install -O1 --skip-build --root %{buildroot} %else %{__python} -c 'import setuptools; execfile("setup.py")' install -O1 --skip-build --root %{buildroot} %endif
Here is the new rpm with all the changes: SPEC: http://huzaifas.fedorapeople.org/spec/python-lzo.spec SRPM: http://huzaifas.fedorapeople.org/srpms/python-lzo-1.08-2.fc8.src.rpm dist-f8 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=547587 dist-f9 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=547582
Review: + package builds in mock. Koji build => dist-f8 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=547587 dist-f9 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=547582 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 292a3b6cdaca606b917e7f6bf026fdad python-lzo-1.08.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Package python-lzo-1.08-2.fc9=> Provides: lzo.so Requires: libc.so.6 libc.so.6(GLIBC_2.1.3) liblzo2.so.2 libpthread.so.0 libpython2.5.so.1.0 python(abi) = 2.5 rtld(GNU_HASH) + Not a GUI app. APPROVED.
New Package CVS Request ======================= Package Name: python-lzo Short Description: Python bindings for lzo compression libraries Owners: huzaifas Branches: F-8, F-9, EPEL-5 InitialCC: huzaifas Cvsextras Commits: Yes
cvs done.
Is this built for all requested branches so that we can close this review?
ping? I can't see package built and tagged with .fc9 on koji
done