Bug 440679 - Review Request: lua-sql - Database connectivity for Lua
Review Request: lua-sql - Database connectivity for Lua
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
Depends On:
Blocks: 440680
  Show dependency treegraph
Reported: 2008-04-04 09:55 EDT by Tim Niemueller
Modified: 2010-11-09 08:02 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-04-08 18:16:29 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
tibbs: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Tim Niemueller 2008-04-04 09:55:25 EDT
Spec URL: http://fedorapeople.org/~timn/luastuff/lua-sql.spec
SRPM URL: http://fedorapeople.org/~timn/luastuff/lua-sql-2.1.1-1.fc8.src.rpm
LuaSQL is a simple interface from Lua to a DBMS. This package of LuaSQL
supports MySQL, SQLite and PostgreSQL databases. You can execute arbitrary SQL
statements and it allows for retrieving results in a row-by-row cursor fashion.

Website: http://www.keplerproject.org/luasql/
Comment 1 Jason Tibbitts 2008-04-04 14:27:51 EDT
This seems to leave lualibdir/luasql unowned.

Also, one of the subpackages seems to require the main package, which seems a
bit odd, given that it creates a circular dependency unless I'm missing something.
Comment 2 Tim Niemueller 2008-04-04 17:36:56 EDT
lualibdir/luasql is now owner by all database sub-packages.

The require is broken. In the first incarnation I actually had this require
because the documentation was in the main package. Then I split this and now the
lua-sql is kind of a meta-package to pull in everything.

New version of spec file uploaded, new SRPM is at
Comment 3 Jason Tibbitts 2008-04-04 20:19:13 EDT
Unfortunately this now fails to build:

gcc -O2  -I../compat/src -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -Wall
-Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement
-Wendif-labels -fno-strict-aliasing -fwrapv -I/usr/include -fPIC   -c -o
src/ls_postgres.o src/ls_postgres.c
export MACOSX_DEPLOYMENT_TARGET="10.3"; gcc -O2  -I../compat/src -O2 -g -pipe
-Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -Wall -Wmissing-prototypes
-Wpointer-arith -Winline -Wdeclaration-after-statement -Wendif-labels
-fno-strict-aliasing -fwrapv -I/usr/include -fPIC -o src/postgres.so -shared 
src/luasql.o src/ls_postgres.o  -lpgport -lxslt -lxml2 -lpam -lssl -lcrypto
-lgssapi_krb5 -lz -lreadline -lcrypt -ldl -lm
/usr/bin/ld: cannot find -lxslt
collect2: ld returned 1 exit status

Needs a build dependency on libxslt, perhaps?
Comment 4 Tim Niemueller 2008-04-05 05:17:04 EDT
libxml2, libxslt and libpam are required by PostgreSQL 8.3 on rawhide - you
might think. But the problem lies deeper: I was using pg_config and
mysql_config, assuming that they produce proper flags for building clients -
failed! They show which flags where used to build the libs and server, cf. bug
#440673. I now pass the proper flags without the "config" tools. Scratch build
executed successfully for dist-f9

New SRPM is at http://fedorapeople.org/~timn/luastuff/lua-sql-2.1.1-3.fc8.src.rpm
Comment 5 Jason Tibbitts 2008-04-07 13:03:23 EDT
luaforge.net seems to be down at the moment; I'll wait a bit to see if it comes
back up before reviewing.
Comment 6 Tim Niemueller 2008-04-07 17:19:33 EDT
Yes, according to the mailing list they are restoring backups. Will take a few
hours. I'll ping you if it comes back up. Maybe you can finish the review of the
other two packages. These should be easy as I already incorporated your
suggested changes.
Comment 7 Jason Tibbitts 2008-04-08 00:20:55 EDT
luaforge.net is back up now, so....

rpmlist says:

  lua-sql.x86_64: E: no-binary
This is true, and is not a problem.

  lua-sql-mysql.x86_64: W: no-documentation
  lua-sql-postgresql.x86_64: W: no-documentation
  lua-sql-sqlite.x86_64: W: no-documentation
These are all OK as well; the documentation is in a separate package.

The base package containing only the README file is kind of odd.  Honestly I
don't really see the point of having it at all; I'd just put the README file in
the -doc package and dispense with the base package altogether.  But I don't
really see any problem with it.

I note that there's some sort of test suite.  Usually database tests can't
really be run at build time and I'm going to assume that's the case here, but if
 if they do happen to be runnable it would be good for you to add a %check section.

* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summaries are OK.
* descriptions are OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   lua-sql = 2.1.1-3.fc9

   lua-sql-doc = 2.1.1-3.fc9
   lua >= 5.1

   lua-sql-mysql = 2.1.1-3.fc9
   lua >= 5.1

   lua-sql-postgresql = 2.1.1-3.fc9
   lua >= 5.1

   lua-sql-sqlite = 2.1.1-3.fc9
   lua >= 5.1

* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

Comment 8 Tim Niemueller 2008-04-08 03:01:29 EDT
You are right about the README file. I'll move it to the -doc package and make
lua-sql a pure meta package to pull in everything.

Thanks for all the thorough reviews!
Comment 9 Tim Niemueller 2008-04-08 03:01:59 EDT
New Package CVS Request
Package Name: lua-sql
Short Description: Database connectivity for Lua
Owners: timn
Branches: F-7 F-8
Cvsextras Commits: yes
Comment 10 Kevin Fenzi 2008-04-08 14:11:48 EDT
cvs done.
Comment 11 Tim Niemueller 2010-11-08 18:33:06 EST
Package Change Request
Package Name: lua-sql
New Branches: el5 el6
Owners: timn
Comment 12 Jason Tibbitts 2010-11-09 08:02:38 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.