Red Hat Bugzilla – Bug 441052
Deinterlace plugins (including tvtime) are removed
Last modified: 2008-04-05 13:08:48 EDT
Description of problem: Looking at the "cleanup-sources" patch for xine-lib, one of the things that it removes is all planar and deinterlace processors; here's an excerpt: # Postprocessors echo "removing planar and deinterlace postprocessors..." sed -i -e 's/deinterlace //g' src/post/Makefile.am # see comments in speedy.c sed -i -e 's/planar //g' src/post/Makefile.am # requires libpostproc sed -i -e '/post\/\(deinterlace\|planar\)/d' configure.ac rm -rf src/post/{deinterlace,planar} Unfortunately, the tvtime deinterlace plugin is used by the KDE4 sound-configuration tool -- don't ask me why, but it is, see bug 440299 for details. Why are these plugins removed? If it's not a legal issue, could they be put back? Version-Release number of selected component (if applicable): xine-lib-1.1.11.1-1.fc9.i386
Here's the comment in speedy.c hinted at in the cleanup-sources.sh comment: /** * Includes 420to422, 422to444 scaling filters from the MPEG2 reference * implementation. The v12 source code indicates that they were written * by Cheung Auyeung <auyeung@mot.com>. The file they were in was: * * store.c, picture output routines * Copyright (C) 1996, MPEG Software Simulation Group. All Rights Reserved. * * Disclaimer of Warranty * * These software programs are available to the user without any license fee or * royalty on an "as is" basis. The MPEG Software Simulation Group disclaims * any and all warranties, whether express, implied, or statuary, including any * implied warranties or merchantability or of fitness for a particular * purpose. In no event shall the copyright-holder be liable for any * incidental, punitive, or consequential damages of any kind whatsoever * arising from the use of these programs. * * This disclaimer of warranty extends to the user of these programs and user's * customers, employees, agents, transferees, successors, and assigns. * * The MPEG Software Simulation Group does not represent or warrant that the * programs furnished hereunder are free of infringement of any third-party * patents. * * Commercial implementations of MPEG-1 and MPEG-2 video, including shareware, * are subject to royalty fees to patent holders. Many of these patents are * general enough such that they are unavoidable regardless of implementation * design. * */ Now whether this particular code is actually subject to some patent or not, I don't know.
The copyright state of that code may or may not be a problem too.
I guess reenabling this code is not an option due to the potential legal issues, so we're just going to make the deinterlacer optional in Phonon with a patch. The link between sound and deinterlacing is that the "sound" settings in KDE are actually multimedia settings and also affect video.
FYI, the fix to the Phonon crash when deinterlacing is not available has been committed to Rawhide and to the upstream 4.1 trunk and 4.0 branch.