Bug 441086 - Review Request: ezstream - Command line source client for Icecast media streaming servers
Summary: Review Request: ezstream - Command line source client for Icecast media strea...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-04-05 23:49 UTC by Ian Weller
Modified: 2008-05-12 21:08 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-05-12 21:08:21 UTC
Type: ---
Embargoed:
j: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Ian Weller 2008-04-05 23:49:26 UTC
Spec URL: http://ianweller.fedorapeople.org/SRPMS/ezstream/0.5.3-1/ezstream.spec
SRPM URL: http://ianweller.fedorapeople.org/SRPMS/ezstream/0.5.3-1/ezstream-0.5.3-1.fc8.src.rpm
Description:
Ezstream is a command line source client for Icecast media streaming servers.
It began as the successor of the old "shout" utility, and has since gained a
lot of useful features.

In its basic mode of operation, it streams media files or data from standard
input without reencoding and thus requires only very little CPU resources. It
can also use various external decoders and encoders to reencode from one format
to another, and stream the result to an Icecast server. Additional features
include scriptable playlist and metadata handling. All of its features make
ezstream a very flexible source client.

Supported media formats for streaming are MP3, Ogg Vorbis and Ogg Theora.
Native metadata support includes MP3 (ID3v1 only) and Ogg Vorbis, and many more
formats when the optional TagLib support has been compiled in (which they are
for this package).

Comment 1 Jason Tibbitts 2008-04-11 05:39:29 UTC
Sorry, I ended up running out of time for a bit there.

Some of the source is MIT licensed, some is GPLv2+ and some is GPLv2.  That does
make the result plain GPLv2.

The obvious question is whether this decodes MP3 in any way, and as far as I can
tell it doesn't, other than parsing the metadata.  It can use external programs
to transcode things to and from MP3 but it doesn't include those programs.

* source files match upstream:
   5f279eab49b6d71441358ef046fdbd3749396cf43818e436239fdb3e004e4ecb  
   ezstream-0.5.3.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   ezstream = 0.5.3-1.fc9
  =
   libogg.so.0()(64bit)
   libshout.so.3()(64bit)
   libspeex.so.1()(64bit)
   libtag_c.so.0()(64bit)
   libtheora.so.0()(64bit)
   libvorbis.so.0()(64bit)
   libvorbisfile.so.3()(64bit)
   libxml2.so.2()(64bit)
   libz.so.1()(64bit)

* %check is not present; no test suite upstream.  I don't really have any idea 
  how to test this.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

Comment 2 Ian Weller 2008-04-11 20:12:28 UTC
New Package CVS Request
=======================
Package Name: ezstream
Short Description: Command line source client for Icecast media streaming servers
Owners: ianweller
Branches: F-8 F-9
InitialCC: 
Cvsextras Commits: yes

Comment 3 Kevin Fenzi 2008-04-12 22:10:07 UTC
cvs done.

Comment 4 Fedora Update System 2008-04-13 00:31:01 UTC
ezstream-0.5.3-1.fc8 has been submitted as an update for Fedora 8

Comment 5 Fedora Update System 2008-04-17 03:49:51 UTC
ezstream-0.5.3-1.fc8 has been pushed to the Fedora 8 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 6 Jason Tibbitts 2008-05-12 20:21:05 UTC
Can we close this now?


Note You need to log in before you can comment on or make changes to this bug.