Bug 442057 - Review Request: mono-nunit22 - Unit-testing framework for .NET
Review Request: mono-nunit22 - Unit-testing framework for .NET
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2008-04-11 10:46 EDT by Tom "spot" Callaway
Modified: 2008-04-11 13:03 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-04-11 13:03:03 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
tcallawa: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Tom "spot" Callaway 2008-04-11 10:46:33 EDT
Spec URL: http://www.auroralinux.org/people/spot/review/new/mono-nunit22.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/mono-nunit22-2.2.10-1.fc9.src.rpm

NUnit is a unit-testing framework for all .Net languages. Initially ported from
JUnit, this xUnit based unit testing tool is written entirely in C# and has
been completely redesigned to take advantage of many .NET language features,
for example custom attributes and other reflection related capabilities. NUnit
brings xUnit to all .NET languages.
Comment 1 Jason Tibbitts 2008-04-11 11:43:35 EDT
This builds OK (although the output is crazy verbose); rpmlint says:

  mono-nunit22.x86_64: W: invalid-license MIT with acknowledgement
rpmlint is a bit behind here.

  mono-nunit22.x86_64: E: no-binary
  mono-nunit22.x86_64: E: only-non-binary-in-usr-lib
These are normal for mono packages.

  mono-nunit22-debuginfo.x86_64: E: empty-debuginfo-package
Indeed, the debuginfo package seems to be completely empty.  Probably best to
disable it.

  mono-nunit22-devel.x86_64: W: no-documentation
That's OK; it's just a .pc file.

I'm going to trust your evaluation of the license so that I don't have to open
a damn rtf viewer.  The world is just full of idiocy, it seems.

So the only issue is the empty debuginfo package; I'll approve this and you
can disable it when you check in.

* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
X debuginfo package is busted.
X rpmlint has a valid complaint about the debuginfo package.
* final provides and requires are sane:
   mono(nunit-console) =
   mono(nunit-console-runner) =
   mono(nunit.core) =
   mono(nunit.core.extensions) =
   mono(nunit.framework) =
   mono(nunit.mocks) =
   mono(nunit.util) =
   mono-nunit22 = 2.2.10-1.fc9
   mono(System) =
   mono(System.Xml) =
   mono(mscorlib) =
   mono(nunit-console-runner) =
   mono(nunit.core) =
   mono(nunit.framework) =
   mono(nunit.util) =

   mono-nunit22-devel = 2.2.10-1.fc9
   mono-nunit22 = 2.2.10-1.fc9

* %check is not present.  I there are tests, but they're run at build time.
  At least that's what it looks like the build-tests targets are doing.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* pkgconfig file is (alone) in the -devel package.

APPROVED; just disable the debuginfo package.
Comment 2 Tom "spot" Callaway 2008-04-11 11:50:01 EDT
Thanks for the quick review.

New Package CVS Request
Package Name: mono-nunit22
Short Description: Unit-testing framework for .NET
Owners: spot
Branches: F-7 F-8 F-9 devel
Cvsextras Commits: yes
Comment 3 Tom "spot" Callaway 2008-04-11 11:54:47 EDT
cvs done.
Comment 4 Tom "spot" Callaway 2008-04-11 13:03:03 EDT
Built for all branches, thanks again.

Note You need to log in before you can comment on or make changes to this bug.