Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
For bugs related to Red Hat Enterprise Linux 5 product line. The current stable release is 5.10. For Red Hat Enterprise Linux 6 and above, please visit Red Hat JIRA https://issues.redhat.com/secure/CreateIssue!default.jspa?pid=12332745 to report new issues.

Bug 442138

Summary: comps.dtd file is missing
Product: Red Hat Enterprise Linux 5 Reporter: Robinson Tiemuqinke <hahaha_30k>
Component: anacondaAssignee: Dave Cantrell <dcantrell>
Status: CLOSED ERRATA QA Contact: Release Test Team <release-test-team-automation>
Severity: urgent Docs Contact:
Priority: low    
Version: 5.1CC: atodorov, dcantrell, ddumas, jlaska, syeghiay, veillard
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-01-20 21:37:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
comps DTD none

Description Robinson Tiemuqinke 2008-04-11 23:47:35 UTC
Description of problem:
 can not locate 'comps.dtd' for XML validation, it is an external reference of 
comps.xml file on installation media. The DTD file is used for users' custom 
RPM group definition file, custom.xml, as well.

Version-Release number of selected component (if applicable):


How reproducible:
 
 always.


Steps to Reproduce:
1. find the installation CDs and can not locate the dtd file.
2. query all the RPMs but still can not find the file
3. google Internet but still can not find it.
  
Actual results:
 can not locate the file.

Expected results:
 it should be at where, like inside the comps RPM, and Internet accessible. 

 
Additional info:
The comps.dtd should be a simple text file and of no other uses besides 
validation Redhat, or Redhat variants Linux Distributions. Please make it 
available through Internet at least.

Comment 1 RHEL Program Management 2008-07-10 16:01:35 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 5 Daniel Veillard 2008-09-05 17:03:47 UTC
My take is the following:
  it should be put somewhere on a public web site (www.redhat.com/fedoraproject.org or rpm.org), preferably with a versionned URL.
Then it should also be installed on local disks possibly as part of the
rpm or yum package, and in the post-install you add it to the XML Catalog
(see http://xmlsoft.org/catalog.html for explanations)

Then in the comps.xml shipped you keep the SYSTEM identifier as the
URL on the public web site but validation will look first in the catalog
and avoid the remote lookup.

Examples of packages doing exactly this are xhtml1-dtds and docbook-dtds

For paths to XML DTDs in the distro and catalogs, this has been discuted
as part of the standardization group, 

/usr/share/xml/comps/1.0/comps.dtd would be just fine, and the
mapping could be added directly in /etc/xml/catalog

Daniel

Comment 6 Dennis Gregorovic 2008-09-05 17:09:55 UTC
Seth, I think it would make sense for the yum package to be the one that includes the comps.dtd file and xml catalog entries.  Do you agree?

Comment 7 seth vidal 2008-09-05 17:12:20 UTC
comps format is driven from anaconda. Yum just supports what anaconda wants to do with it. It might make more sense for it to be in anaconda.

Comment 10 Dave Cantrell 2008-09-25 02:44:47 UTC
Having anaconda provide comps.dtd in an RPM is probably the easiest way considering comps is a special component in the distribution.

You guys just want to remove it from the comps package in dist-cvs and add it to anaconda?  We can install it as part of anaconda-runtime.  Then we just need to update the comps files to reference the comps.dtd location correctly on the filesystem.

Comment 11 Dennis Gregorovic 2008-09-25 03:21:08 UTC
Created attachment 317649 [details]
comps DTD

Comment 12 Dennis Gregorovic 2008-09-25 03:22:39 UTC
Sounds good.  I've moved this bug to the anaconda component and attached the comps.dtd file.

Comment 13 Dave Cantrell 2008-09-25 03:52:49 UTC
Where should this file be installed on the system?

Comment 14 Denise Dumas 2008-09-26 13:15:52 UTC
Adding exception flag

Comment 15 Dave Cantrell 2008-09-29 23:47:43 UTC
I will get this bug taken care of and add the comps.dtd file if someone can tell me where on the system

Comment 16 Dave Cantrell 2008-09-30 01:12:03 UTC
OK, comps.dtd added to /usr/share/xml/comps/1.0 as comps.dtd.  The file is part of the anaconda-runtime package and now anaconda-runtime will depend on xml-common and the libxml2 package (for xmlcatalog).

I do not know where DTD files should live on our http servers, so I'm going to punt that decision to someone else's to do stack.  The comps*.xml files I see in the current RHEL 5 trees just reference "comps.dtd" at the top, so I have added this as the %post script for the anaconda-runtime package:

CATALOG=/etc/xml/catalog
/usr/bin/xmlcatalog --noout --add "rewriteSystem" \
    "comps.dtd" \
    "/usr/share/xml/comps/1.0/comps.dtd" $CATALOG
/usr/bin/xmlcatalog --noout --add "rewriteURI" \
    "comps.dtd" \
    "/usr/share/xml/comps/1.0/comps.dtd" $CATALOG
|| :

When/if the comps.dtd file is published on an HTTP site, we change the rewrite rule generation here.

Comment 18 Dave Cantrell 2008-09-30 21:48:44 UTC
Fixed in anaconda-11.1.2.133-1

Comment 21 errata-xmlrpc 2009-01-20 21:37:49 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-0164.html