Red Hat Bugzilla – Bug 442218
Review Request: taglib-sharp - Provides tag reading and writing for Banshee and other Mono apps
Last modified: 2008-04-12 21:26:28 EDT
Spec URL: http://www.auroralinux.org/people/spot/review/new/taglib-sharp.spec SRPM URL: http://www.auroralinux.org/people/spot/review/new/taglib-sharp-2.0.3.0-1.fc9.src.rpm Description: TagLib# is a FREE and Open Source library for the .NET 2.0 and Mono frameworks which will let you tag your software with as much or as little detail as you like without slowing you down. It supports a large variety of movie and music formats which abstract away the work, handling all the different cases, so all you have to do is access file.Tag.Title, file.Tag.Lyrics, or my personal favorite file.Tag.Pictures. But don't think all this abstraction is gonna keep you from tagging's greatest gems. You can still get to a specific tag type's features with just a few lines of code. NOTE: We need this to bring Banshee up to spec in F-9.
OK, try: New SRPM: http://www.auroralinux.org/people/spot/review/new/taglib-sharp-2.0.3.0-2.fc9.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/new/taglib-sharp.spec
No, really, try: New SRPM: http://www.auroralinux.org/people/spot/review/new/taglib-sharp-2.0.3.0-3.fc9.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/new/taglib-sharp.spec
Package Review (taglib-sharp-2.0.3.0-2.fc9.src.rpm) ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/x86_64 [x] Rpmlint output: source RPM: empty binary RPM: taglib-sharp.x86_64: E: no-binary taglib-sharp.x86_64: E: only-non-binary-in-usr-lib taglib-sharp-devel.x86_64: E: only-non-binary-in-usr-lib --> false alarms [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type:LGPLv2+ note: sources are a mix of different licenses but LGPLv2+ seems to be the common denominator [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. SHA1SUM of package: 648a26d64df48e460e0a196b99bc706d11f726f0 taglib-sharp-2.0.3.0-3.fc9.src.rpm [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [x] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [x] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [x] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: devel/x86_64 [?] Package should compile and build into binary rpms on all supported architectures. Tested on: [?] Package functions as described. [-] Scriptlets must be sane, if used. [x] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. ================ *** APPROVED *** ================
obs: there is only one minor nitpick: pkgconfig gets pulled in by mono-devel which would count as an [indirect] duplicate BR
I'll fix that before I commit, thanks. New Package CVS Request ======================= Package Name: taglib-sharp Short Description: Provides tag reading and writing for Banshee and other Mono apps Owners: spot Branches: F-7 F-8 F-9 devel InitialCC: Cvsextras Commits: yes
cvs done.
Built, thanks.