Red Hat Bugzilla – Bug 442693
Review Request: geoclue - Geoclue is a modular geoinformation service
Last modified: 2008-05-18 17:06:04 EDT
Spec URL: http://fedora.roving-it.com/rawhide/geoclue.spec
SRPM URL: http://fedora.roving-it.com/rawhide/geoclue-0.10-0.1.20080415git.fc9.src.rpm
Description: Geoclue is a modular geoinformation service built on top of the D-Bus messaging system. The goal of the Geoclue project is to make creating location-aware applications as simple as possible.
Hey, thanks for picking this up, it was on my list of things to look at...
Some preliminary comments on the spec file:
This looks wrong, only devel packages should require devel packages:
These will almost certainly be pulled in automatically be library dependencies,
so no need to list them explicitly:
The devel package must require pkgconfig, since it contains a pc file.
The description is misleading, since the devel package should _not_ contain
static libraries. It should contain the unversioned symlinks (.so) for shared
Running autogen.sh should only be necessary when building from a checkout. Even
if this package is based on a git snapshot right now, the tarball should be
produced by 'make dist' and the autogen.sh call should be unnecessary. If it
were necessary for some reason, then you are missing the necessary BuildRequires
for automake, autoconf, etc
missing from the file list:
As expected, trying to build your srpm in mock fails with
which: no libtoolize in
libtoolize not found. Please install it.
due to the missing BuildRequires for the autogen.sh call
No problems. Been looking for some packages to maintain for a while to get
geoclue has just done another release so the autogen.sh stuff can disappear, but
there's a missing file from the tar ball as far as I can tell so I'll upload a
new version once I can get it to build.
For the static libraries do I just rm them from the build?
OK new version
with static libraries, do you mean .la files ? those are actually libtool
archives, and yes, rm is the right treatment for them. Actual static libaries
are .a files, but you are configuring with --disable-static, so those should not
be produced in the first place. I they are, then again rm is the easiest solution.
the .la files are removed in the last spec file so I think I've got the
I was able to build this in mock, so we are getting somewhere. rpmlint has some
geoclue.i386: E: zero-length /usr/share/doc/geoclue-0.11.1/ChangeLog
geoclue.i386: E: library-without-ldconfig-postin /usr/lib/libgeoclue.so.0.0.0
geoclue.i386: E: library-without-ldconfig-postun /usr/lib/libgeoclue.so.0.0.0
geoclue.i386: E: zero-length /usr/share/doc/geoclue-0.11.1/NEWS
geoclue.i386: E: description-line-too-long Geoclue is a modular geoinformation
service built on top of the D-Bus messaging system. The goal of the Geoclue
project is to make creating location-aware applications as simple as possible.
geoclue.i386: W: non-standard-group System
geoclue.i386: W: invalid-license LGPL
all of these are easy fixes, thankfully.
OK, I think I've fixed all of those errors. I've put the main library rpm in the
"System Environment/Libraries" but not sure what group the test gui should go
in. Maybe its just late but I can't see anything in the packaging guidelines
Yeah, looks fine now, basically. For rpm groups, I would just pick something like
Development/Libraries, since the demo is about showing how to use the geoclue
I'll do a formal review sometime this weekend.
Fixed up the group for the test gui, also removed the gtk requirement as it
should get it automatically.
Thanks for the feedback.
Builds fine in mock.
[mclasen@localhost Desktop]$ rpmlint
geoclue-devel.i386: W: no-documentation
geoclue-gui.i386: W: no-documentation
Both of which are ignorable warnings.
package name: ok
spec file name: ok
packaging guidelines: ok
license field: ok
license file: ok
spec file language: ok
spec file legibility: outstanding
upstream sources: ok
build deps: ok
locale handling: ok
directory ownership: ok
duplicate files: ok
file permissions: ok
documentation: the api docs should be moved to the -devel package
static libs: n/a
pkgconfig files: ok
shared libraries: ok
devel package: ok
libtool archives: ok
gui apps: n/a
file ownership: ok
utf8 filenames: ok
Approved, but please move the api docs to the -devel package.
I'll also note that the first attemot to run the test gui yields a segfault for
me, the second run succeeds. Something to look into...
I've move the api docs out to the devel rpm.
I'm seeing the same issues with the test gui as well, I've filed an upstream
bug. b.f.o bug # 15745
I've already set the approval flag, so you can proceed and request cvs now,
unless you need sponsorship, in which case I cannot help :-(
Peter, have you made any progress towards finding a sponsor yet ?
No, not having much luck on that front, also been very busy with other things
too. I'm not 100% on the best way to get sponsorship, although have been looking
at reviews for other packages but haven't posted any updates to them as yet. Any
other pointers for sponsorship?
I have recently become a sponsor, so I can now sponsor you.
The canonical information about this is
You'll have to set up a Fedora Account first. For that, see
I already have a fedoraprojects account. Username is pbrobinson
After some head scratching, I have figured out that you need to go the account
system ( http://admin.fedoraproject.org/accounts ), login and request membership
in the cvsextras group.
Actually, I could do it myself. You should be able to proceed and request cvs now.
New Package CVS Request
Package Name: geoclue
Short Description: Geoclue is a modular geoinformation service
Branches: F-8 F-9
Cvsextras Commits: yes
I think I inadvertently closed this by accident
cvs done (with "a modular geoinformation service" as short description).
In CVS and built in Koji. As far as I can see this now will be pushed to
rawhide, and I need to request builds Bodhi for F9/F8?
Fixed. geoclue is now in rawhide and Fedora-9 testing updates. Updated package
to include sub packages for gypsy and gpsd