Bug 442937 - libblkid sees lvm2pv as swap
Summary: libblkid sees lvm2pv as swap
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: e2fsprogs
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Eric Sandeen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F9Blocker
TreeView+ depends on / blocked
 
Reported: 2008-04-17 18:00 UTC by Jeremy Katz
Modified: 2008-04-18 19:21 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-04-18 17:55:20 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
fix (1.27 KB, patch)
2008-04-17 18:00 UTC, Jeremy Katz
no flags Details | Diff

Description Jeremy Katz 2008-04-17 18:00:32 UTC
libblkid ends up seeing an lvm2pv as a swap partition instead because swap is
earlier in the table.  lvm2pv should probably be the first thing probed instead
of the last as it's a container.  See attached patch

Comment 1 Jeremy Katz 2008-04-17 18:00:32 UTC
Created attachment 302779 [details]
fix

Comment 2 Eric Sandeen 2008-04-17 22:00:15 UTC
Bleah, what a mess.

Neither mkswap nor pvcreate does a great job of zeroing other signatures around
the new signature.  For some incantations, pvcreate-then-mkswap has an initial
4k on the disk which is *identical* to mkswap-then-pvcreate.  :(

Sent a patch upstream (and to Jeremy) to check that the swap v1 header has a
valid version and page count... "pvcreate" by itself will zero those.  (pvcreate
-u <blah> will not, unfortunately, so there's still a small hole).

But, it fixes Jeremy's case:

# blkid -c /dev/null /root/md0-for-esandeen 
/root/md0-for-esandeen: UUID="kyOPnO-Biwa-PssU-PsXx-kJDW-36Ry-iZvqk5" TYPE="lvm2pv"

Comment 4 Jeremy Katz 2008-04-18 17:55:20 UTC
Patch committed and built and I tested it with my reproducer, so going to close


Note You need to log in before you can comment on or make changes to this bug.